From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sumit Gupta <sumitg@nvidia.com>
Cc: rjw@rjwysocki.net, catalin.marinas@arm.com, will@kernel.org,
thierry.reding@gmail.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, jonathanh@nvidia.com,
talho@nvidia.com, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bbasu@nvidia.com,
mperttunen@nvidia.com
Subject: Re: [TEGRA194_CPUFREQ Patch v3 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property
Date: Mon, 22 Jun 2020 12:52:47 +0530 [thread overview]
Message-ID: <20200622072247.agrvmw6sl3jwgjkz@vireshk-i7> (raw)
In-Reply-To: <1592775274-27513-2-git-send-email-sumitg@nvidia.com>
On 22-06-20, 03:04, Sumit Gupta wrote:
> To do frequency scaling on all CPUs within T194 CPU Complex, we need
> to query BPMP for data on valid operating points. Document a compatible
> string under 'cpus' node to represent the CPU Complex for binding drivers
> like cpufreq which don't have their node or CPU Complex node to bind to.
> Also, document a property to point to the BPMP device that can be queried
> for all CPUs.
You shouldn't be putting how linux is going to use this information and entries
shouldn't be made just so cpufreq can bind to a driver.
Though I see that this is a real hardware register which you can use to interact
with the firmware ? And so it makes sense to have it, maybe in different form
though.
I will let Rob explain what would be the right way of doing this though.
>
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> Documentation/devicetree/bindings/arm/cpus.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> index a018147..737b55e 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> @@ -162,6 +162,7 @@ properties:
> - nvidia,tegra132-denver
> - nvidia,tegra186-denver
> - nvidia,tegra194-carmel
> + - nvidia,tegra194-ccplex
> - qcom,krait
> - qcom,kryo
> - qcom,kryo260
> @@ -255,6 +256,14 @@ properties:
>
> where voltage is in V, frequency is in MHz.
>
> + nvidia,bpmp:
> + $ref: '/schemas/types.yaml#/definitions/phandle'
> + descrption: |
> + Specifies the bpmp node that needs to be queried to get
> + operating point data for all CPUs.
> +
> + Optional for NVIDIA Tegra194 Carmel CPUs
> +
> power-domains:
> $ref: '/schemas/types.yaml#/definitions/phandle-array'
> description:
> --
> 2.7.4
--
viresh
next prev parent reply other threads:[~2020-06-22 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 21:34 [TEGRA194_CPUFREQ Patch v3 0/4] Add cpufreq driver for Tegra194 Sumit Gupta
2020-06-21 21:34 ` [TEGRA194_CPUFREQ Patch v3 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property Sumit Gupta
2020-06-22 7:22 ` Viresh Kumar [this message]
2020-06-23 6:05 ` Sumit Gupta
2020-06-21 21:34 ` [TEGRA194_CPUFREQ Patch v3 2/4] arm64: tegra: " Sumit Gupta
2020-06-21 21:34 ` [TEGRA194_CPUFREQ Patch v3 3/4] cpufreq: Add Tegra194 cpufreq driver Sumit Gupta
2020-06-22 7:20 ` Viresh Kumar
2020-06-23 5:19 ` Sumit Gupta
2020-06-23 6:20 ` Viresh Kumar
2020-06-21 21:34 ` [TEGRA194_CPUFREQ Patch v3 4/4] arm64: defconfig: Enable CONFIG_ARM_TEGRA194_CPUFREQ Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622072247.agrvmw6sl3jwgjkz@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=bbasu@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sumitg@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).