* [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices
@ 2020-06-22 8:34 Lee Jones
2020-07-07 12:11 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2020-06-22 8:34 UTC (permalink / raw)
To: robh+dt, devicetree, linus.walleij
Cc: linux-arm-kernel, linux-kernel, Lee Jones
As per 'struct mfd_cell ab8500_devs[]' there are not 1, but 3 PWM
devices on the AB8500. Until now, each of them have referenced
the same Device Tree node. This change ensures each device has
their own.
Due to recent `dtc` checks [0], nodes cannot share the same node
name, so we are forced to rename the affected nodes by appending
their associated numeric 'bank ID'.
[0] ste-ab8500.dtsi:210.16-214.7: ERROR (duplicate_node_names):
/soc/prcmu@80157000/ab8500/ab8500-pwm: Duplicate node name
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/boot/dts/ste-ab8500.dtsi | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ste-ab8500.dtsi b/arch/arm/boot/dts/ste-ab8500.dtsi
index 3cd6ee6d50e0e..aab5719cc1a93 100644
--- a/arch/arm/boot/dts/ste-ab8500.dtsi
+++ b/arch/arm/boot/dts/ste-ab8500.dtsi
@@ -201,7 +201,19 @@ ab8500-sysctrl {
compatible = "stericsson,ab8500-sysctrl";
};
- ab8500-pwm {
+ ab8500-pwm-1 {
+ compatible = "stericsson,ab8500-pwm";
+ clocks = <&ab8500_clock AB8500_SYSCLK_INT>;
+ clock-names = "intclk";
+ };
+
+ ab8500-pwm-2 {
+ compatible = "stericsson,ab8500-pwm";
+ clocks = <&ab8500_clock AB8500_SYSCLK_INT>;
+ clock-names = "intclk";
+ };
+
+ ab8500-pwm-3 {
compatible = "stericsson,ab8500-pwm";
clocks = <&ab8500_clock AB8500_SYSCLK_INT>;
clock-names = "intclk";
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices
2020-06-22 8:34 [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices Lee Jones
@ 2020-07-07 12:11 ` Linus Walleij
2020-07-07 12:13 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2020-07-07 12:11 UTC (permalink / raw)
To: Lee Jones
Cc: Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux ARM, linux-kernel
On Mon, Jun 22, 2020 at 10:34 AM Lee Jones <lee.jones@linaro.org> wrote:
> As per 'struct mfd_cell ab8500_devs[]' there are not 1, but 3 PWM
> devices on the AB8500. Until now, each of them have referenced
> the same Device Tree node. This change ensures each device has
> their own.
>
> Due to recent `dtc` checks [0], nodes cannot share the same node
> name, so we are forced to rename the affected nodes by appending
> their associated numeric 'bank ID'.
>
> [0] ste-ab8500.dtsi:210.16-214.7: ERROR (duplicate_node_names):
> /soc/prcmu@80157000/ab8500/ab8500-pwm: Duplicate node name
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices
2020-07-07 12:11 ` Linus Walleij
@ 2020-07-07 12:13 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-07-07 12:13 UTC (permalink / raw)
To: Lee Jones
Cc: Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux ARM, linux-kernel, Stephan Gerhold
On Tue, Jul 7, 2020 at 2:11 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Jun 22, 2020 at 10:34 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> > As per 'struct mfd_cell ab8500_devs[]' there are not 1, but 3 PWM
> > devices on the AB8500. Until now, each of them have referenced
> > the same Device Tree node. This change ensures each device has
> > their own.
> >
> > Due to recent `dtc` checks [0], nodes cannot share the same node
> > name, so we are forced to rename the affected nodes by appending
> > their associated numeric 'bank ID'.
> >
> > [0] ste-ab8500.dtsi:210.16-214.7: ERROR (duplicate_node_names):
> > /soc/prcmu@80157000/ab8500/ab8500-pwm: Duplicate node name
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Patch applied!
BTW shouldn't we also patch ste-ab8505.dts?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-07 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 8:34 [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices Lee Jones
2020-07-07 12:11 ` Linus Walleij
2020-07-07 12:13 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).