From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B77EC433E1 for ; Mon, 22 Jun 2020 13:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61C632073E for ; Mon, 22 Jun 2020 13:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729093AbgFVNrH (ORCPT ); Mon, 22 Jun 2020 09:47:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:52788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728449AbgFVNrG (ORCPT ); Mon, 22 Jun 2020 09:47:06 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA66A20732; Mon, 22 Jun 2020 13:47:05 +0000 (UTC) Date: Mon, 22 Jun 2020 09:47:04 -0400 From: Steven Rostedt To: Peter Enderborg Cc: Greg Kroah-Hartman , , "Rafael J . Wysocki" , Andrew Morton , Jonathan Corbet , , Randy Dunlap , Ingo Molnar Subject: Re: [PATCH 1/2] tracefs: Remove unnecessary debug_fs checks. Message-ID: <20200622094704.589220a9@oasis.local.home> In-Reply-To: <20200622083019.15479-2-peter.enderborg@sony.com> References: <20200617133738.6631-1-peter.enderborg@sony.com> <20200622083019.15479-1-peter.enderborg@sony.com> <20200622083019.15479-2-peter.enderborg@sony.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2020 10:30:18 +0200 Peter Enderborg wrote: > This is a preparation for debugfs restricted mode. > We don't need debugfs to trace, the removed check stop tracefs to work > if debugfs is not initialised. We instead tries to automount within > debugfs and relay on it's handling. The code path is to create a > backward compatibility from when tracefs was part of debugfs, it is now > standalone and does not need debugfs. When debugfs is in restricted > it is compiled in but not active and return EPERM to clients and > tracefs wont work if it assumes it is active it is compiled in > kernel. > > Reported-by: kernel test robot > Signed-off-by: Peter Enderborg Acked-by: Steven Rostedt (VMware) -- Steve > --- > kernel/trace/trace.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index ec44b0e2a19c..34ed82364edb 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -8946,9 +8946,7 @@ struct dentry *tracing_init_dentry(void) > if (tr->dir) > return NULL; > > - if (WARN_ON(!tracefs_initialized()) || > - (IS_ENABLED(CONFIG_DEBUG_FS) && > - WARN_ON(!debugfs_initialized()))) > + if (WARN_ON(!tracefs_initialized())) > return ERR_PTR(-ENODEV); > > /*