From: Kees Cook <keescook@chromium.org>
To: Fangrui Song <maskray@google.com>
Cc: Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] vmlinux.lds.h: Add .gnu.version* to DISCARDS
Date: Mon, 22 Jun 2020 15:57:21 -0700 [thread overview]
Message-ID: <202006221555.45BB6412F@keescook> (raw)
In-Reply-To: <20200622225237.ybol4qmz4mhkmlqc@google.com>
On Mon, Jun 22, 2020 at 03:52:37PM -0700, Fangrui Song wrote:
> > And it's not in the output:
> >
> > $ readelf -Vs arch/x86/boot/compressed/vmlinux | grep version
> > No version information found in this file.
> >
> > So... for the kernel we need to silence it right now.
>
> Re-link with -M (or -Map file) to check where .gnu.version{,_d,_r} input
> sections come from?
It's not reporting it correctly:
.gnu.version_d 0x00000000008966b0 0x0
.gnu.version_d
0x00000000008966b0 0x0 arch/x86/boot/compressed/kernel_info.o
.gnu.version 0x00000000008966b0 0x0
.gnu.version 0x00000000008966b0 0x0 arch/x86/boot/compressed/kernel_info.o
.gnu.version_r 0x00000000008966b0 0x0
.gnu.version_r
0x00000000008966b0 0x0 arch/x86/boot/compressed/kernel_info.o
it just reports whatever file is listed on the link command line first.
> If it is a bug, we should probably figure out which version of binutils
> has fixed the bug.
I see this with binutils 2.34...
--
Kees Cook
next prev parent reply other threads:[~2020-06-22 22:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 20:53 [PATCH v2 0/3] x86: Warn on orphan section placement Kees Cook
2020-06-22 20:53 ` [PATCH v2 1/3] vmlinux.lds.h: Add .gnu.version* to DISCARDS Kees Cook
2020-06-22 22:00 ` Fangrui Song
2020-06-22 22:09 ` Kees Cook
2020-06-22 22:27 ` Kees Cook
2020-06-22 22:52 ` Fangrui Song
2020-06-22 22:57 ` Kees Cook [this message]
2020-06-22 23:04 ` Fāng-ruì Sòng
2020-06-22 23:30 ` Kees Cook
2020-06-22 20:53 ` [PATCH v2 2/3] x86/build: Warn on orphan section placement Kees Cook
2020-06-22 20:53 ` [PATCH v2 3/3] x86/boot: " Kees Cook
2020-06-22 22:06 ` Fangrui Song
2020-06-22 22:35 ` Kees Cook
2020-06-22 22:43 ` Kees Cook
2020-06-22 22:49 ` Fangrui Song
2020-06-22 23:00 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006221555.45BB6412F@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maskray@google.com \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).