From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Oleksandr Natalenko <oleksandr@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Felix Fietkau <nbd@nbd.name>, Ryder Lee <ryder.lee@mediatek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-mediatek@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: mt7612 suspend/resume issue
Date: Mon, 22 Jun 2020 18:02:17 +0200 [thread overview]
Message-ID: <20200622160217.GD27892@localhost.localdomain> (raw)
In-Reply-To: <CAHcwAbR1W_aOaozr=m48UCWKPr1m71bk-c+kwkGd6A2GTLGF6A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]
> On Mon, Jun 22, 2020 at 4:53 PM Lorenzo Bianconi
> <lorenzo.bianconi@redhat.com> wrote:
> > > On Sun, Jun 21, 2020 at 10:54 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> > > > > > +static int __maybe_unused
> > > > > > +mt76x2e_suspend(struct pci_dev *pdev, pm_message_t state)
> > > > > > +{
> > > > > > + struct mt76_dev *mdev = pci_get_drvdata(pdev);
> > > > > > + struct mt76x02_dev *dev = container_of(mdev, struct mt76x02_dev, mt76);
> > > > > > + int i, err;
> > > >
> > > > can you please double-check what is the PCI state requested during suspend?
> > >
> > > Do you mean ACPI S3 (this is the state the system enters)? If not,
> > > what should I check and where?
> >
> > yes, right. Just for debugging, can you please force the card in PCI_D0 during the
> > suspend?
>
> Do you want me to do this:
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> index 5543e242fb9b..e558342cce03 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> @@ -119,9 +119,8 @@ mt76x2e_suspend(struct pci_dev *pdev, pm_message_t state)
>
> mt76x02_dma_reset(dev);
>
> - pci_enable_wake(pdev, pci_choose_state(pdev, state), true);
> pci_save_state(pdev);
> - err = pci_set_power_state(pdev, pci_choose_state(pdev, state));
> + err = pci_set_power_state(pdev, PCI_D0);
> if (err)
> goto restore;
I think you can just substitute pci_choose_state(pdev, state) with PCI_D0, not
removing pci_enable_wake()
Regards,
Lorenzo
>
> ?
>
> --
> Best regards,
> Oleksandr Natalenko (post-factum)
> Principal Software Maintenance Engineer
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2020-06-22 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 9:05 mt7612 suspend/resume issue Oleksandr Natalenko
2020-06-18 11:18 ` Lorenzo Bianconi
2020-06-19 15:01 ` Oleksandr Natalenko
2020-06-21 20:54 ` Lorenzo Bianconi
2020-06-22 14:48 ` Oleksandr Natalenko
2020-06-22 14:53 ` Lorenzo Bianconi
2020-06-22 15:47 ` Oleksandr Natalenko
2020-06-22 16:02 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622160217.GD27892@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=oleksandr@redhat.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).