From: David Miller <davem@davemloft.net>
To: jarod@redhat.com
Cc: linux-kernel@vger.kernel.org, borisp@mellanox.com,
saeedm@mellanox.com, leon@kernel.org, j.vosburgh@gmail.com,
vfalico@gmail.com, andy@greyhouse.net,
jeffrey.t.kirsher@intel.com, kuba@kernel.org,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bonding/xfrm: use real_dev instead of slave_dev
Date: Tue, 23 Jun 2020 15:20:09 -0700 (PDT) [thread overview]
Message-ID: <20200623.152009.1181630031177940079.davem@davemloft.net> (raw)
In-Reply-To: <20200623204001.55030-1-jarod@redhat.com>
From: Jarod Wilson <jarod@redhat.com>
Date: Tue, 23 Jun 2020 16:40:01 -0400
> Rather than requiring every hw crypto capable NIC driver to do a check for
> slave_dev being set, set real_dev in the xfrm layer and xso init time, and
> then override it in the bonding driver as needed. Then NIC drivers can
> always use real_dev, and at the same time, we eliminate the use of a
> variable name that probably shouldn't have been used in the first place,
> particularly given recent current events.
>
> CC: Boris Pismenny <borisp@mellanox.com>
> CC: Saeed Mahameed <saeedm@mellanox.com>
> CC: Leon Romanovsky <leon@kernel.org>
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> CC: "David S. Miller" <davem@davemloft.net>
> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Jakub Kicinski <kuba@kernel.org>
> CC: Steffen Klassert <steffen.klassert@secunet.com>
> CC: Herbert Xu <herbert@gondor.apana.org.au>
> CC: netdev@vger.kernel.org
> Suggested-by: Saeed Mahameed <saeedm@mellanox.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
Yes this is much nicer.
Applied, thank you.
prev parent reply other threads:[~2020-06-23 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 20:40 [PATCH net-next] bonding/xfrm: use real_dev instead of slave_dev Jarod Wilson
2020-06-23 22:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623.152009.1181630031177940079.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=borisp@mellanox.com \
--cc=herbert@gondor.apana.org.au \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=steffen.klassert@secunet.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).