From: David Miller <davem@davemloft.net>
To: cjhuang@codeaurora.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org
Subject: Re: [PATCH] net: qrtr: free flow in __qrtr_node_release
Date: Tue, 23 Jun 2020 20:26:29 -0700 (PDT) [thread overview]
Message-ID: <20200623.202629.352077396302165327.davem@davemloft.net> (raw)
In-Reply-To: <1592882523-12870-1-git-send-email-cjhuang@codeaurora.org>
From: Carl Huang <cjhuang@codeaurora.org>
Date: Tue, 23 Jun 2020 11:22:03 +0800
> @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref)
> struct radix_tree_iter iter;
> unsigned long flags;
> void __rcu **slot;
> + struct qrtr_tx_flow *flow;
Please retain the reverse christmas tree ordering of local variables here.
Thanks.
next prev parent reply other threads:[~2020-06-24 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 3:22 [PATCH] net: qrtr: free flow in __qrtr_node_release Carl Huang
2020-06-24 3:26 ` David Miller [this message]
2020-06-29 11:50 ` cjhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623.202629.352077396302165327.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ath11k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).