From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D70C433DF for ; Tue, 23 Jun 2020 20:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 403C22098B for ; Tue, 23 Jun 2020 20:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945177; bh=ws8BzZB8g1upQCbMjiyvcwajLytfvmMGBkpxrNv9/60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hteSygLnffZ+N/3fnL/+STnY9atRTdoRs/DX3BWISvVShy82XnLKAPaxJejwVbHx3 P7l8GTaXBeU0Wuz3s8yEOW8afeu0Ylq55Oc3HEbUWsWF0rmWdI2e4lTYC2otnfrdys bA/Qfzfe3PoU5JIY383FzuGhBRwwM8r7ftNdXrOU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392813AbgFWUqO (ORCPT ); Tue, 23 Jun 2020 16:46:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:43860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404014AbgFWUqF (ORCPT ); Tue, 23 Jun 2020 16:46:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE75021582; Tue, 23 Jun 2020 20:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945165; bh=ws8BzZB8g1upQCbMjiyvcwajLytfvmMGBkpxrNv9/60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mp2rU3JK4jS5+z4sJpAFroIO9kpmAiBgksn8ELq8uzYwUVoFhvCnl0T/jXyyR3qpX EL+JNFe9a1oB9fCxzTxkLw6t3hLu91ls4CiOuHUeHqAI8n9+Lu3GXnauoYk6dskcGl eLxDmyZe6t7SjcT7+V/V839AYmGvEq3iBeuIvc/Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhang Shengju , Tang Bin , Peter Chen , Sasha Levin Subject: [PATCH 4.14 063/136] USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe() Date: Tue, 23 Jun 2020 21:58:39 +0200 Message-Id: <20200623195306.861840998@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin [ Upstream commit d49292025f79693d3348f8e2029a8b4703be0f0a ] The function ehci_mxc_drv_probe() does not perform sufficient error checking after executing platform_get_irq(), thus fix it. Fixes: 7e8d5cd93fac ("USB: Add EHCI support for MX27 and MX31 based boards") Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Reviewed-by: Peter Chen Link: https://lore.kernel.org/r/20200513132647.5456-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/ehci-mxc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index c7a9b31eeaeff..637079a350032 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -63,6 +63,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev)); if (!hcd) -- 2.25.1