From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31996C433DF for ; Tue, 23 Jun 2020 20:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDC2A217BA for ; Tue, 23 Jun 2020 20:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945410; bh=gMpAb/ZZpi5zacxHMyAQXaX3k0m9CwTdxfUeRQnHUrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yvYOn1KmLG1hvxyGPJ30dLV6DuiV8AXIHODxOtdWXEtNEzWFtXnHidfcXlxnTL86l x3VLXTUj0pdQfBoBxPHjfbbs/fDq+9tFWxXcN8XPalwhTyFZc6YUIy7h6C7FX/myUS Rl16fKBqJ4w8TrJi48dM0zlZVdQzRahmW5QQEw7E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390702AbgFWUuI (ORCPT ); Tue, 23 Jun 2020 16:50:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:48476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404143AbgFWUtH (ORCPT ); Tue, 23 Jun 2020 16:49:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FF3C2098B; Tue, 23 Jun 2020 20:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945346; bh=gMpAb/ZZpi5zacxHMyAQXaX3k0m9CwTdxfUeRQnHUrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sWgHAFWISuDhfFV5QB1uVNkVp5ijZO/Xrk0yw617Mtck80d1Y2/Ar/U5QYy2nb2W2 9lK41IZTEtYl2L7n4qXTXYwUskzZI3WL7v0nEIVK8tE1DfYruxyw80ZsSihmI/wgQQ G2QSstOb+ZyEu46S6wyNOUSIb9teyVsw0I02B2TA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adrian Hunter , Alexander Shishkin , Ingo Molnar , Jiri Olsa , Kan Liang , Mark Rutland , Namhyung Kim , Peter Zijlstra , Gaurav Singh , Sasha Levin Subject: [PATCH 4.14 106/136] perf report: Fix NULL pointer dereference in hists__fprintf_nr_sample_events() Date: Tue, 23 Jun 2020 21:59:22 +0200 Message-Id: <20200623195309.009008965@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gaurav Singh [ Upstream commit 11b6e5482e178055ec1f2444b55f2518713809d1 ] The 'evname' variable can be NULL, as it is checked a few lines back, check it before using. Fixes: 9e207ddfa207 ("perf report: Show call graph from reference events") Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/ Signed-off-by: Gaurav Singh Signed-off-by: Sasha Levin --- tools/perf/builtin-report.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 429c3e140dc32..35a10b5985447 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -401,8 +401,7 @@ static size_t hists__fprintf_nr_sample_events(struct hists *hists, struct report if (evname != NULL) ret += fprintf(fp, " of event '%s'", evname); - if (symbol_conf.show_ref_callgraph && - strstr(evname, "call-graph=no")) { + if (symbol_conf.show_ref_callgraph && evname && strstr(evname, "call-graph=no")) { ret += fprintf(fp, ", show reference callgraph"); } -- 2.25.1