From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F8CCC433DF for ; Tue, 23 Jun 2020 20:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 601D12158C for ; Tue, 23 Jun 2020 20:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945337; bh=99SVTbKuXuVGfxLyubVnHdU5fnd+FTvCuJ0neJ30//U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1PGYvNXxB1LGrraPmxitUx5AYtR6+R29O6GQGZ127ohbJHJrzm1mCvA3IoHJrub1m j4rzJP5Z1NcAm0zt3MEgjNdnp4aGo+7dZLCSC3zS4ZFuUZyuyxJmcuyh7pTLCpQIwI wEN1R60ebKvBzFKKf86FD2npSoN2NLu8TTN3V/y0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404129AbgFWUsz (ORCPT ); Tue, 23 Jun 2020 16:48:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:47920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404097AbgFWUsp (ORCPT ); Tue, 23 Jun 2020 16:48:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED71921548; Tue, 23 Jun 2020 20:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945326; bh=99SVTbKuXuVGfxLyubVnHdU5fnd+FTvCuJ0neJ30//U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NOrfEz/Il886lpglavomT/V8yy9cKksdZRuIkSDii6fj5+adzckeg0LeNVHzMO9J6 yGCj7cBGeny3ca8T1cIoCoEu/OHFpu6N6EwwosgY8A0rqSJtIsgYFZ9lGik5+sczjy CPTc38puqRhjd83RgGKAeo7PANL0GDLUAUe5rECg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Sasha Levin Subject: [PATCH 4.14 127/136] mtd: rawnand: plat_nand: Fix the probe error path Date: Tue, 23 Jun 2020 21:59:43 +0200 Message-Id: <20200623195310.196967757@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal [ Upstream commit 5284024b4dac5e94f7f374ca905c7580dbc455e9 ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no real Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible, hence pointing it as the commit to fix for backporting purposes, even if this commit is not introducing any bug. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-43-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/plat_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c index 2906996d22620..8c2d1c5c95691 100644 --- a/drivers/mtd/nand/plat_nand.c +++ b/drivers/mtd/nand/plat_nand.c @@ -99,7 +99,7 @@ static int plat_nand_probe(struct platform_device *pdev) if (!err) return err; - nand_release(&data->chip); + nand_cleanup(&data->chip); out: if (pdata->ctrl.remove) pdata->ctrl.remove(pdev); -- 2.25.1