From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B45DEC433E0 for ; Tue, 23 Jun 2020 20:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89F1820836 for ; Tue, 23 Jun 2020 20:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944528; bh=4SIfEj1YrHh/Avucg1lbUHiS57pFuWFmy8f4WwCMHfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gZyljaHdfxt7r8a35eEc0dN0nRVLjsPo7LCaPuMiCS+V39ZynPqNA0LYHwvv2yyU5 EPda8BuuT3CU8uMuBzbgZQ8IKqdZpC25yiNr2up7tNfo1xMtvjKYqHI5OI973auvH7 3M5w9FbkwcWI0P6W84LZR6IvQ3/gHQbvXkCazNzw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391243AbgFWUfX (ORCPT ); Tue, 23 Jun 2020 16:35:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:57508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391572AbgFWUfN (ORCPT ); Tue, 23 Jun 2020 16:35:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B376E2080C; Tue, 23 Jun 2020 20:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944514; bh=4SIfEj1YrHh/Avucg1lbUHiS57pFuWFmy8f4WwCMHfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKQ6CinyByOopS13mw1yoVqdXtoQL5gjQXYpbsZ9MmPlUkfHrg/uwXMG2bwFpwxNB BBpsNEaxNWXGN/q031sbjhbJwThuBSCLwp2PpICEk+KUln7v+B2H/c9123mTcKZj2t AtymB/zLqhHlNsIiXzK7aDhACT3R98OaFVqGzgDc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rikard Falkeborn , Maxime Ripard , Sasha Levin Subject: [PATCH 4.19 002/206] clk: sunxi: Fix incorrect usage of round_down() Date: Tue, 23 Jun 2020 21:55:30 +0200 Message-Id: <20200623195317.005514754@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rikard Falkeborn [ Upstream commit ee25d9742dabed3fd18158b518f846abeb70f319 ] round_down() can only round to powers of 2. If round_down() is asked to round to something that is not a power of 2, incorrect results are produced. The incorrect results can be both too large and too small. Instead, use rounddown() which can round to any number. Fixes: 6a721db180a2 ("clk: sunxi: Add A31 clocks support") Signed-off-by: Rikard Falkeborn Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/clk/sunxi/clk-sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 004b411b640b3..2bd035d488161 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -98,7 +98,7 @@ static void sun6i_a31_get_pll1_factors(struct factors_request *req) * Round down the frequency to the closest multiple of either * 6 or 16 */ - u32 round_freq_6 = round_down(freq_mhz, 6); + u32 round_freq_6 = rounddown(freq_mhz, 6); u32 round_freq_16 = round_down(freq_mhz, 16); if (round_freq_6 > round_freq_16) -- 2.25.1