From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30B6C433DF for ; Tue, 23 Jun 2020 20:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DE472064B for ; Tue, 23 Jun 2020 20:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592943352; bh=SeSGWd2X1m6STHYPCLvNZM29tgba9bTjz7pF92Kqekc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uiQBbe7G6arM/tVmUZWvHefHiTqUqCh2TqVden5rx3wUJSQm7SSvRV/FrXSBsjMzW JFIaFhUlPav3dtBLUnEQoJqBSMrPypJtRjVu+FsANRXi7uig1HpgEIdBgwsMNvelTW 4u/L/3pnoK+50HKa06tGZaaQF1GghwkOXZEfe0sA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389077AbgFWUPu (ORCPT ); Tue, 23 Jun 2020 16:15:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389329AbgFWUPg (ORCPT ); Tue, 23 Jun 2020 16:15:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B53520702; Tue, 23 Jun 2020 20:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592943336; bh=SeSGWd2X1m6STHYPCLvNZM29tgba9bTjz7pF92Kqekc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cWNFwz/bT6B8Skuo0O+uA1dK+L37IFd9sxwlPW05PisXI1+pmduWFzajnW/0FlKVo kZO2gUEQWamY1nE0K3EOFi6iTqxsTsGvW2Ed0aOdS79mgyZ6h0bLwlch7omGbvJP0V F0gu71A0kNcQRsrUcdCHlai0V7mhUId8e88qnVg4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhihao Cheng , David Howells , Sasha Levin Subject: [PATCH 5.7 353/477] afs: Fix memory leak in afs_put_sysnames() Date: Tue, 23 Jun 2020 21:55:50 +0200 Message-Id: <20200623195424.228113979@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhihao Cheng [ Upstream commit 2ca068be09bf8e285036603823696140026dcbe7 ] Fix afs_put_sysnames() to actually free the specified afs_sysnames object after its reference count has been decreased to zero and its contents have been released. Fixes: 6f8880d8e681557 ("afs: Implement @sys substitution handling") Signed-off-by: Zhihao Cheng Signed-off-by: David Howells Signed-off-by: Sasha Levin --- fs/afs/proc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/proc.c b/fs/afs/proc.c index 468e1713bce13..6f34c84a0fd0a 100644 --- a/fs/afs/proc.c +++ b/fs/afs/proc.c @@ -563,6 +563,7 @@ void afs_put_sysnames(struct afs_sysnames *sysnames) if (sysnames->subs[i] != afs_init_sysname && sysnames->subs[i] != sysnames->blank) kfree(sysnames->subs[i]); + kfree(sysnames); } } -- 2.25.1