From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26510C433DF for ; Wed, 24 Jun 2020 21:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0805B207E8 for ; Wed, 24 Jun 2020 21:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404858AbgFXVsM (ORCPT ); Wed, 24 Jun 2020 17:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404563AbgFXVsM (ORCPT ); Wed, 24 Jun 2020 17:48:12 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B4EC061573; Wed, 24 Jun 2020 14:48:12 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9C09F12737AF7; Wed, 24 Jun 2020 14:48:11 -0700 (PDT) Date: Wed, 24 Jun 2020 14:48:10 -0700 (PDT) Message-Id: <20200624.144810.1787595389624931255.davem@davemloft.net> To: s.hauer@pengutronix.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kernel@pengutronix.de, linux@armlinux.org.uk Subject: Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes From: David Miller In-Reply-To: <20200624070045.8878-1-s.hauer@pengutronix.de> References: <20200624070045.8878-1-s.hauer@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 Jun 2020 14:48:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:44 +0200 > In mvneta_config_interface() the RGMII modes are catched by the default > case which is an error return. The RGMII modes are valid modes for the > driver, so instead of returning an error add a break statement to return > successfully. > > This avoids this warning for non comphy SoCs which use RGMII, like > SolidRun Clearfog: > > WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c > > Signed-off-by: Sascha Hauer Applied.