From: Jason Gunthorpe <jgg@ziepe.ca>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL
Date: Wed, 24 Jun 2020 09:39:10 -0300 [thread overview]
Message-ID: <20200624123910.GA3178169@ziepe.ca> (raw)
In-Reply-To: <159300126338.4527.3968787379471939056@build.alporthouse.com>
On Wed, Jun 24, 2020 at 01:21:03PM +0100, Chris Wilson wrote:
> Quoting Jason Gunthorpe (2020-06-24 13:10:53)
> > On Wed, Jun 24, 2020 at 09:02:47AM +0100, Chris Wilson wrote:
> > > When direct reclaim enters the shrinker and tries to reclaim pages, it
> > > has to opportunitically unmap them [try_to_unmap_one]. For direct
> > > reclaim, the calling context is unknown and may include attempts to
> > > unmap one page of a dma object while attempting to allocate more pages
> > > for that object. Pass the information along that we are inside an
> > > opportunistic unmap that can allow that page to remain referenced and
> > > mapped, and let the callback opt in to avoiding a recursive wait.
> >
> > i915 should already not be holding locks shared with the notifiers
> > across allocations that can trigger reclaim. This is already required
> > to use notifiers correctly anyhow - why do we need something in the
> > notifiers?
>
> for (n = 0; n < num_pages; n++)
> pin_user_page()
>
> may call try_to_unmap_page from the lru shrinker for [0, n-1].
Yes, of course you can't hold any locks that intersect with notifiers
across pin_user_page()/get_user_page()
It has always been that way.
I consolidated all this tricky locking into interval notifiers, maybe
updating i915 to use them will give it a solution. I looked at it
once, it was straightforward enough until it got to all the #ifdefery
> We're in the middle of allocating the object, how are we best to untangle
> that?
I don't know anything about i915, but this is clearly i915 not using
notifiers properly, it needs proper fixing, not hacking up notifiers.
Jason
next prev parent reply other threads:[~2020-06-24 12:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 8:02 [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL Chris Wilson
2020-06-24 8:02 ` [PATCH 2/2] drm/i915/gem: Use mmu_notifier_range_mayfail() to avoid waiting inside reclaim Chris Wilson
2020-06-24 12:10 ` [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL Jason Gunthorpe
2020-06-24 12:21 ` Chris Wilson
2020-06-24 12:39 ` Jason Gunthorpe [this message]
2020-06-24 14:12 ` Chris Wilson
2020-06-24 14:16 ` Jason Gunthorpe
2020-06-24 14:21 ` Chris Wilson
2020-06-24 14:25 ` Jason Gunthorpe
2020-06-24 14:37 ` Chris Wilson
2020-06-24 16:50 ` Jason Gunthorpe
2020-06-24 17:58 ` Chris Wilson
2020-06-24 18:48 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624123910.GA3178169@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).