From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E18C433DF for ; Wed, 24 Jun 2020 13:26:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9FFB20738 for ; Wed, 24 Jun 2020 13:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593005170; bh=JmFbJS0PXLoFzco2T3g6Do+UUnsYW2aYLUOdaY8lj+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rB+pXrwU3k34eleG+KHfPvftgCvfUpI4dUPDVD4CkghG8pgRjle2K+8hvbs9r6COS SEvQIrJoGrQ4bccNfwRVesMkmQHymkf5vL9ZaNvwTbXdSTA2Hxl56MhK6oHh28RCpw mYwlf7yEVI/E2ksavYgPEwg0/EZwsg99PQCe3jQU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390144AbgFXN0F (ORCPT ); Wed, 24 Jun 2020 09:26:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:53986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387687AbgFXNZf (ORCPT ); Wed, 24 Jun 2020 09:25:35 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2EA720738; Wed, 24 Jun 2020 13:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593005135; bh=JmFbJS0PXLoFzco2T3g6Do+UUnsYW2aYLUOdaY8lj+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I0ghPOxMhm6dri4CB1uByEKsnodv/HbTXGlazQSBuzPHznhC5brjUCLVLAYURDLXq mRTxA2V01ONTgnjLhHWgAZqqulK4hB0upnbtXvRAMWEVVQngyoaecajufaz5tdIN9I YJrOr8x6CBw5QxolcEvBjTCMrqhBA8ziYD7lXAKU= Date: Wed, 24 Jun 2020 14:25:32 +0100 From: Mark Brown To: Andrzej Hajda Cc: Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com, Russell King - ARM Linux , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Daniel Vetter , "open list:DRM DRIVERS" Subject: Re: [RESEND PATCH v5 4/5] drm/bridge/sii8620: fix resource acquisition error handling Message-ID: <20200624132532.GC5472@sirena.org.uk> References: <20200624114127.3016-1-a.hajda@samsung.com> <20200624114127.3016-5-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kVXhAStRUZ/+rrGn" Content-Disposition: inline In-Reply-To: <20200624114127.3016-5-a.hajda@samsung.com> X-Cookie: So this is it. We're going to die. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kVXhAStRUZ/+rrGn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 24, 2020 at 01:41:26PM +0200, Andrzej Hajda wrote: > In case of error during resource acquisition driver should print error > message only in case it is not deferred probe, using probe_err helper > solves the issue. Moreover it records defer probe reason for debugging. If we silently ignore all deferred probe errors we make it hard for anyone who is experiencing issues with deferred probe to figure out what they're missing. We should at least be logging problems at debug level so there's something for people to go on without having to hack the kernel source. --kVXhAStRUZ/+rrGn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7zVEwACgkQJNaLcl1U h9Adowf/bt19xA4Q3/G5xTijEYnOc63YWxQGFynpEFvnpuQuTYuDRwL2ybQHpXkD 7dZqUsmE//n9XDWNSi6IHolSzWRtBVqD+LpF/gmGHcqGsPCstcSLeQMVM5b4l5KV x59+x9cTfoYkQ2XoBNZmmWZwGBYqVJvhW+4TysUX+9JCZgxKOG1LXLuMlL7r9qP2 5nI549k1sjQdiC8pevFkysGucfiOGoKIQfcpMqqlIzCFkBCt5pRTYNQ0e4jUh3gT 8qVPKlbm99aJ5+TGjPWtUzndU9VM08psKQNnguznxAbaHhF+ZA11l1AiIPv2qHkn YtM+Bz+sHfeDkTCKefTLds0G3+8Mmg== =oY2K -----END PGP SIGNATURE----- --kVXhAStRUZ/+rrGn--