Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on linux/master linus/master ipvs/master v5.8-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/yunaixin03610-163-com/Adding-Huawei-BMA-drivers/20200623-014140 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next.git master config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:67:5: warning: no previous prototype for 'edma_param_get_statics' [-Wmissing-prototypes] 67 | int edma_param_get_statics(char *buf, const struct kernel_param *kp) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:142:5: warning: no previous prototype for '__atu_config_H' [-Wmissing-prototypes] 142 | s32 __atu_config_H(struct pci_dev *pdev, unsigned int region, | ^~~~~~~~~~~~~~ In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:20, from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:21: drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: In function 'ioremap_pme_bar1_mem': >> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:80:17: error: implicit declaration of function 'ioremap_nocache'; did you mean 'ioremap_cache'? [-Werror=implicit-function-declaration] 80 | #define IOREMAP ioremap_nocache | ^~~~~~~~~~~~~~~ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:246:7: note: in expansion of macro 'IOREMAP' 246 | IOREMAP(bma_pci_dev->bma_base_phy_addr, | ^~~~~~~ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:245:30: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 245 | bma_pci_dev->bma_base_addr = | ^ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: In function 'ioremap_bar_mem': drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:310:31: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 310 | bma_pci_dev->kbox_base_addr = | ^ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: At top level: drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:328:5: warning: no previous prototype for 'pme_pci_enable_msi' [-Wmissing-prototypes] 328 | int pme_pci_enable_msi(struct pci_dev *pdev) | ^~~~~~~~~~~~~~~~~~ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:354:5: warning: no previous prototype for 'pci_device_init' [-Wmissing-prototypes] 354 | int pci_device_init(struct pci_dev *pdev, struct bma_pci_dev_s *bma_pci_dev) | ^~~~~~~~~~~~~~~ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:383:5: warning: no previous prototype for 'pci_device_config' [-Wmissing-prototypes] 383 | int pci_device_config(struct pci_dev *pdev) | ^~~~~~~~~~~~~~~~~ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:505:12: warning: no previous prototype for 'bma_pci_init' [-Wmissing-prototypes] 505 | int __init bma_pci_init(void) | ^~~~~~~~~~~~ drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:518:13: warning: no previous prototype for 'bma_pci_cleanup' [-Wmissing-prototypes] 518 | void __exit bma_pci_cleanup(void) | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +80 drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h 76 77 #ifdef CONFIG_ARM64 78 #define IOREMAP ioremap_wc 79 #else > 80 #define IOREMAP ioremap_nocache 81 #endif 82 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org