From: Ramzi Ben Meftah <rbmeftah@de.adit-jv.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Ramzi BEN MEFTAH <rbmeftah@de.adit-jv.com>,
niklas soderlund <niklas.soderlund@ragnatech.se>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Steve Longerbeam <steve_longerbeam@mentor.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Arnd Bergmann <arnd@arndb.de>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Michael Rodin <mrodin@de.adit-jv.com>,
<efriedrich@de.adit-jv.com>, <erosca@de.adit-jv.com>
Subject: Re: [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT
Date: Thu, 25 Jun 2020 11:30:46 +0200 [thread overview]
Message-ID: <20200625093046.GA91893@vmlxhi-110.adit-jv.com> (raw)
In-Reply-To: <20200625020138.GW5980@pendragon.ideasonboard.com>
Hi Laurent,
On Thu, Jun 25, 2020 at 05:01:38AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Wed, Jun 24, 2020 at 09:53:07AM +0200, Jacopo Mondi wrote:
> > On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote:
> > > From: Steve Longerbeam <steve_longerbeam@mentor.com>
> >
> > +Niklas, +Laurent
> >
> > Niklas, Laurent, how does this play with CAP_IO_MC ?
>
> I don't think it's related to CAP_IO_MC, but I don't think it's a good
> idea either :-) Routing doesn't go through the subdev [gs]_input
> operations in MC-based drivers. It should be configured through link
> setup instead. This patch goes in the wrong direction, sorry Steve.
ENUMINPUT ioctl allow to get the input signal status. Is there an alternative
with Media Controller?
>
> > > This commit enables VIDIOC_ENUMINPUT, VIDIOC_G_INPUT, and VIDIOC_S_INPUT
> > > ioctls for use via v4l2 subdevice node.
> > >
> > > This commit should probably not be pushed upstream, because the (old)
> > > idea of video inputs conflicts with the newer concept of establishing
> > > media links between src->sink pads.
> > >
> > > However it might make sense for some subdevices to support enum/get/set
> > > inputs. One example would be the analog front end subdevice for the
> > > ADV748x. By providing these ioctls, selecting the ADV748x analog inputs
> > > can be done without requiring the implementation of media entities that
> > > would define the analog source for which to establish a media link.
> > >
> > > Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> > > ---
> > > drivers/media/v4l2-core/v4l2-subdev.c | 9 +++++++++
> > > include/media/v4l2-subdev.h | 11 +++++++++++
> > > 2 files changed, 20 insertions(+)
> > >
> > > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> > > index 6b989fe..73fbfe9 100644
> > > --- a/drivers/media/v4l2-core/v4l2-subdev.c
> > > +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> > > @@ -378,6 +378,15 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg)
> > > return -ENOTTY;
> > > return v4l2_querymenu(vfh->ctrl_handler, arg);
> > >
> > > + case VIDIOC_ENUMINPUT:
> > > + return v4l2_subdev_call(sd, video, enuminput, arg);
> > > +
> > > + case VIDIOC_G_INPUT:
> > > + return v4l2_subdev_call(sd, video, g_input, arg);
> > > +
> > > + case VIDIOC_S_INPUT:
> > > + return v4l2_subdev_call(sd, video, s_input, *(u32 *)arg);
> > > +
> > > case VIDIOC_G_CTRL:
> > > if (!vfh->ctrl_handler)
> > > return -ENOTTY;
> > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > > index f7fe78a..6e1a9cd 100644
> > > --- a/include/media/v4l2-subdev.h
> > > +++ b/include/media/v4l2-subdev.h
> > > @@ -383,6 +383,14 @@ struct v4l2_mbus_frame_desc {
> > > * @g_input_status: get input status. Same as the status field in the
> > > * &struct &v4l2_input
> > > *
> > > + * @enuminput: enumerate inputs. Should return the same input status as
> > > + * @g_input_status if the passed input index is the currently active
> > > + * input.
> > > + *
> > > + * @g_input: returns the currently active input index.
> > > + *
> > > + * @s_input: set the active input.
> > > + *
> > > * @s_stream: used to notify the driver that a video stream will start or has
> > > * stopped.
> > > *
> > > @@ -423,6 +431,9 @@ struct v4l2_subdev_video_ops {
> > > int (*g_tvnorms)(struct v4l2_subdev *sd, v4l2_std_id *std);
> > > int (*g_tvnorms_output)(struct v4l2_subdev *sd, v4l2_std_id *std);
> > > int (*g_input_status)(struct v4l2_subdev *sd, u32 *status);
> > > + int (*enuminput)(struct v4l2_subdev *sd, struct v4l2_input *input);
> > > + int (*g_input)(struct v4l2_subdev *sd, u32 *index);
> > > + int (*s_input)(struct v4l2_subdev *sd, u32 index);
> > > int (*s_stream)(struct v4l2_subdev *sd, int enable);
> > > int (*g_pixelaspect)(struct v4l2_subdev *sd, struct v4l2_fract *aspect);
> > > int (*g_frame_interval)(struct v4l2_subdev *sd,
>
> --
> Regards,
>
> Laurent Pinchart
--
Best Regards,
Ramzi Ben Meftah.
next prev parent reply other threads:[~2020-06-25 9:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 10:00 [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT Ramzi BEN MEFTAH
2020-06-16 10:00 ` [PATCH 2/3] media: i2c: adv748x-afe: Implement enum/get/set input Ramzi BEN MEFTAH
2020-06-16 10:00 ` [PATCH 3/3] media: i2c: adv748x: add enuminput control to adv748x hdmi subdev Ramzi BEN MEFTAH
2020-06-24 7:53 ` [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT Jacopo Mondi
2020-06-25 2:01 ` Laurent Pinchart
2020-06-25 9:30 ` Ramzi Ben Meftah [this message]
2020-06-25 9:47 ` Laurent Pinchart
2020-06-25 10:18 ` Ramzi Ben Meftah
2020-06-25 10:29 ` Laurent Pinchart
2020-06-25 10:35 ` Hans Verkuil
2020-06-26 9:09 ` Ramzi Ben Meftah
2020-06-26 9:15 ` Ramzi Ben Meftah
2020-06-26 9:25 ` Hans Verkuil
2020-06-26 10:28 ` Ramzi Ben Meftah
2020-06-25 17:41 ` Steve Longerbeam
2020-06-26 1:12 ` Laurent Pinchart
2020-06-29 9:24 ` Ramzi Ben Meftah
2020-06-29 9:34 ` Laurent Pinchart
2020-06-24 10:08 ` Hans Verkuil
2020-06-24 10:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625093046.GA91893@vmlxhi-110.adit-jv.com \
--to=rbmeftah@de.adit-jv.com \
--cc=arnd@arndb.de \
--cc=efriedrich@de.adit-jv.com \
--cc=erosca@de.adit-jv.com \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=jacopo@jmondi.org \
--cc=jmkrzyszt@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mrodin@de.adit-jv.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).