From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-actions@lists.infradead.org
Subject: Re: [PATCH v2 2/6] dt-bindings: clock: Add APB, DMAC, GPIO bindings for Actions S500 SoC
Date: Thu, 25 Jun 2020 15:50:58 +0300 [thread overview]
Message-ID: <20200625125058.GA7400@BV030612LT> (raw)
In-Reply-To: <159303816030.62212.1603754983340876289@swboyd.mtv.corp.google.com>
On Wed, Jun 24, 2020 at 03:36:00PM -0700, Stephen Boyd wrote:
> Quoting Cristian Ciocaltea (2020-06-24 10:47:53)
> > diff --git a/include/dt-bindings/clock/actions,s500-cmu.h b/include/dt-bindings/clock/actions,s500-cmu.h
> > index 030981cd2d56..a391d1651257 100644
> > --- a/include/dt-bindings/clock/actions,s500-cmu.h
> > +++ b/include/dt-bindings/clock/actions,s500-cmu.h
> > @@ -33,45 +33,48 @@
> > #define CLK_BISP 15
> > #define CLK_VCE 16
> > #define CLK_VDE 17
> > +#define CLK_APB 18
> > +#define CLK_DMAC 19
> >
> > /* peripheral device clock */
> > -#define CLK_TIMER 18
> > -#define CLK_I2C0 19
> > -#define CLK_I2C1 20
> > -#define CLK_I2C2 21
> > -#define CLK_I2C3 22
> > -#define CLK_PWM0 23
> > -#define CLK_PWM1 24
> > -#define CLK_PWM2 25
> > -#define CLK_PWM3 26
> > -#define CLK_PWM4 27
> > -#define CLK_PWM5 28
> > -#define CLK_SD0 29
> > -#define CLK_SD1 30
> > -#define CLK_SD2 31
> > -#define CLK_SENSOR0 32
> > -#define CLK_SENSOR1 33
> > -#define CLK_SPI0 34
> > -#define CLK_SPI1 35
> > -#define CLK_SPI2 36
> > -#define CLK_SPI3 37
> > -#define CLK_UART0 38
> > -#define CLK_UART1 39
> > -#define CLK_UART2 40
> > -#define CLK_UART3 41
> > -#define CLK_UART4 42
> > -#define CLK_UART5 43
> > -#define CLK_UART6 44
> > -#define CLK_DE1 45
> > -#define CLK_DE2 46
> > -#define CLK_I2SRX 47
> > -#define CLK_I2STX 48
> > -#define CLK_HDMI_AUDIO 49
> > -#define CLK_HDMI 50
> > -#define CLK_SPDIF 51
> > -#define CLK_NAND 52
> > -#define CLK_ECC 53
> > -#define CLK_RMII_REF 54
>
> This number can't change. Just add new defines after and update the
> CLK_NR_CLKS define.
Thanks for pointing this out, I wasn't aware of this restriction.
I will add CLK_GPIO immediately after CLK_RMII_REF, since it is part
of the same peripheral device clock group, then I continue with CLK_APB
and CLK_DMAC, documenting that they belong to the system clock group
above.
>
> > +#define CLK_GPIO 20
> > +#define CLK_TIMER 21
> > +#define CLK_I2C0 22
> > +#define CLK_I2C1 23
> > +#define CLK_I2C2 24
> > +#define CLK_I2C3 25
> > +#define CLK_PWM0 26
> > +#define CLK_PWM1 27
> > +#define CLK_PWM2 28
> > +#define CLK_PWM3 29
> > +#define CLK_PWM4 30
> > +#define CLK_PWM5 31
> > +#define CLK_SD0 32
> > +#define CLK_SD1 33
> > +#define CLK_SD2 34
> > +#define CLK_SENSOR0 35
> > +#define CLK_SENSOR1 36
> > +#define CLK_SPI0 37
> > +#define CLK_SPI1 38
> > +#define CLK_SPI2 39
> > +#define CLK_SPI3 40
> > +#define CLK_UART0 41
> > +#define CLK_UART1 42
> > +#define CLK_UART2 43
> > +#define CLK_UART3 44
> > +#define CLK_UART4 45
> > +#define CLK_UART5 46
> > +#define CLK_UART6 47
> > +#define CLK_DE1 48
> > +#define CLK_DE2 49
> > +#define CLK_I2SRX 50
> > +#define CLK_I2STX 51
> > +#define CLK_HDMI_AUDIO 52
> > +#define CLK_HDMI 53
> > +#define CLK_SPDIF 54
> > +#define CLK_NAND 55
> > +#define CLK_ECC 56
> > +#define CLK_RMII_REF 57
next prev parent reply other threads:[~2020-06-25 12:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 17:47 [PATCH v2 0/6] Add RMU and DMAC/GPIO clock support for Actions Semi S500 SoCs Cristian Ciocaltea
2020-06-24 17:47 ` [PATCH v2 1/6] clk: actions: Fix h_clk for Actions S500 SoC Cristian Ciocaltea
2020-06-26 13:45 ` Manivannan Sadhasivam
2020-06-26 15:49 ` Cristian Ciocaltea
2020-06-24 17:47 ` [PATCH v2 2/6] dt-bindings: clock: Add APB, DMAC, GPIO bindings " Cristian Ciocaltea
[not found] ` <159303816030.62212.1603754983340876289@swboyd.mtv.corp.google.com>
2020-06-25 12:50 ` Cristian Ciocaltea [this message]
2020-06-24 17:47 ` [PATCH v2 3/6] clk: actions: Add APB, DMAC, GPIO clock support " Cristian Ciocaltea
2020-06-24 17:47 ` [PATCH v2 4/6] dt-bindings: reset: Add binding constants for Actions S500 RMU Cristian Ciocaltea
2020-06-26 12:14 ` Philipp Zabel
2020-06-24 17:47 ` [PATCH v2 5/6] clk: actions: Add Actions S500 SoC Reset Management Unit support Cristian Ciocaltea
2020-06-26 13:52 ` Manivannan Sadhasivam
2020-06-24 17:47 ` [PATCH v2 6/6] MAINTAINERS: Add reset binding entry for Actions Semi Owl SoCs Cristian Ciocaltea
2020-06-26 13:54 ` Manivannan Sadhasivam
2020-06-26 15:58 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625125058.GA7400@BV030612LT \
--to=cristian.ciocaltea@gmail.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).