From: "Guido Günther" <agx@sigxcpu.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] drm/etnaviv: Ignore MC bit when checking for runtime suspend
Date: Thu, 25 Jun 2020 16:55:03 +0200 [thread overview]
Message-ID: <20200625145503.GA48167@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <4c61fde86c5e0dced249221dbc0a8d4207d5bffa.camel@pengutronix.de>
Hi,
On Tue, Mar 03, 2020 at 12:55:04PM +0100, Lucas Stach wrote:
> On Mo, 2020-03-02 at 20:13 +0100, Guido Günther wrote:
> > At least GC7000 fails to enter runtime suspend for long periods of time since
> > the MC becomes busy again even when the FE is idle. The rest of the series
> > makes detecting similar issues easier to debug in the future by checking
> > all known bits in debugfs and also warning in the EBUSY case.
>
> Thanks, series applied to etnaviv/next.
>
> > Tested on GC7000 with a reduced runtime delay of 50ms. Patches are
> > against next-20200226.
>
> I've already wondered if 200ms is too long, 50ms sounds more
> reasonable. Do you have any numbers on the power draw on the i.MX8M
> with idle GPU, vs. being fully power gated?
The difference is at least 250mW. It makes a huge difference over here.
We hit
https://lore.kernel.org/dri-devel/20200614064601.7872-1-navid.emamdoost@gmail.com/
recently and you notice instantly when that happens when looking at the
SoC temperature.
Cheers,
-- Guido
>
> Regards,
> Lucas
>
> > Thanks to Lucas Stach for pointing me in the right direction.
> >
> > Guido Günther (5):
> > drm/etnaviv: Fix typo in comment
> > drm/etnaviv: Update idle bits
> > drm/etnaviv: Consider all kwnown idle bits in debugfs
> > drm/etnaviv: Ignore MC when checking runtime suspend idleness
> > drm/etnaviv: Warn when GPU doesn't idle fast enough
> >
> > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 26 ++++++++++++++++++++++----
> > drivers/gpu/drm/etnaviv/state_hi.xml.h | 7 +++++++
> > 2 files changed, 29 insertions(+), 4 deletions(-)
> >
>
prev parent reply other threads:[~2020-06-25 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 19:13 [PATCH 0/5] drm/etnaviv: Ignore MC bit when checking for runtime suspend Guido Günther
2020-03-02 19:13 ` [PATCH 1/5] drm/etnaviv: Fix typo in comment Guido Günther
2020-03-02 19:13 ` [PATCH 2/5] drm/etnaviv: Update idle bits Guido Günther
2020-03-02 19:13 ` [PATCH 3/5] drm/etnaviv: Consider all kwnown idle bits in debugfs Guido Günther
2020-03-02 19:13 ` [PATCH 4/5] drm/etnaviv: Ignore MC when checking runtime suspend idleness Guido Günther
2020-03-02 19:13 ` [PATCH 5/5] drm/etnaviv: Warn when GPU doesn't idle fast enough Guido Günther
2020-03-03 11:55 ` [PATCH 0/5] drm/etnaviv: Ignore MC bit when checking for runtime suspend Lucas Stach
2020-03-03 15:49 ` Guido Günther
2020-06-25 14:55 ` Guido Günther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625145503.GA48167@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).