From: Vinod Koul <vkoul@kernel.org>
To: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>
Cc: Vinod Koul <vkoul@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/3] ALSA: compress: Document stream states and fix gapless SM
Date: Thu, 25 Jun 2020 21:16:48 +0530 [thread overview]
Message-ID: <20200625154651.99758-1-vkoul@kernel.org> (raw)
Srini found issue with gapless implementation which prompted to look deeper
into SM for compressed stream.
So documenting SM was first step, so first two patches add that. Last patch
fixes the issue by keeping track on partial_drain and then moving state to
'running' in snd_compr_drain_notify() for partial_drain case on success.
While at it, noticed snd_compr_drain_notify() is lockless state change, so
fixed that as well.
I have tested this on Dragon board RB3, compressed audio works out of the
box on that platform and Srini will send driver and fcplay patches for
gapless soon.
Changes in v3:
- Add pause->stop->free transition
- Add setup->free transition
- remove running->free as that goes thru stop
Changes in v2:
- Added tested tag by Srini
- Update compress SM with Free state and compr_stop() transitions
Vinod Koul (3):
ALSA: compress: document the compress audio state machine
ALSA: compress: document the compress gapless audio state machine
ALSA: compress: fix partial_drain completion state
.../sound/designs/compress-offload.rst | 83 +++++++++++++++++++
include/sound/compress_driver.h | 12 ++-
sound/core/compress_offload.c | 4 +
3 files changed, 98 insertions(+), 1 deletion(-)
--
2.26.2
next reply other threads:[~2020-06-25 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 15:46 Vinod Koul [this message]
2020-06-25 15:46 ` [PATCH v3 1/3] ALSA: compress: document the compress audio state machine Vinod Koul
2020-06-26 10:45 ` Charles Keepax
2020-06-25 15:46 ` [PATCH v3 2/3] ALSA: compress: document the compress gapless " Vinod Koul
2020-06-25 15:46 ` [PATCH v3 3/3] ALSA: compress: fix partial_drain completion state Vinod Koul
2020-06-26 10:35 ` Charles Keepax
2020-06-29 5:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625154651.99758-1-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).