From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()'
Date: Fri, 26 Jun 2020 00:10:29 +0100 [thread overview]
Message-ID: <20200625231029.GN1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200625204730.943520-1-christophe.jaillet@wanadoo.fr>
On Thu, Jun 25, 2020 at 10:47:30PM +0200, Christophe JAILLET wrote:
> The dev_id used in 'request_irq()' and 'free_irq()' should match.
> Use 'info' in both cases.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks Christophe.
> ---
> V2: update free_irq instead of request_irq in order not to obviously break
> code
> ---
> drivers/scsi/arm/cumana_2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/arm/cumana_2.c b/drivers/scsi/arm/cumana_2.c
> index 65691c21f133..29294f0ef8a9 100644
> --- a/drivers/scsi/arm/cumana_2.c
> +++ b/drivers/scsi/arm/cumana_2.c
> @@ -450,7 +450,7 @@ static int cumanascsi2_probe(struct expansion_card *ec,
>
> if (info->info.scsi.dma != NO_DMA)
> free_dma(info->info.scsi.dma);
> - free_irq(ec->irq, host);
> + free_irq(ec->irq, info);
>
> out_release:
> fas216_release(host);
> --
> 2.25.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-06-25 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 7:35 [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()' Christophe JAILLET
2020-05-30 9:43 ` Russell King - ARM Linux admin
2020-05-30 10:41 ` Marion & Christophe JAILLET
2020-06-25 20:47 ` Christophe JAILLET
2020-06-25 23:10 ` Russell King - ARM Linux admin [this message]
2020-06-27 3:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625231029.GN1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).