linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC
@ 2020-06-26 12:05 Johan Jonker
  2020-06-26 12:05 ` [PATCH 2/2] net: stmmac: add Rockchip as supported platform in STMMAC_PLATFORM help text Johan Jonker
  2020-06-26 20:21 ` [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Johan Jonker @ 2020-06-26 12:05 UTC (permalink / raw)
  To: peppe.cavallaro
  Cc: alexandre.torgue, joabreu, davem, kuba, mcoquelin.stm32, heiko,
	linux-rockchip, netdev, linux-stm32, linux-arm-kernel,
	linux-kernel

When a Rockchip user wants to enable support for
the ethernet controller one has to search for
something with STMicroelectronics.
Change the Kconfig menu entry to STMMAC/DWMAC,
so that it better reflects the options it enables.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
index 36bd2e18f..8f7625cc8 100644
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config STMMAC_ETH
-	tristate "STMicroelectronics Multi-Gigabit Ethernet driver"
+	tristate "STMMAC/DWMAC Multi-Gigabit Ethernet driver"
 	depends on HAS_IOMEM && HAS_DMA
 	select MII
 	select MDIO_XPCS
@@ -26,7 +26,7 @@ config STMMAC_SELFTESTS
 	  results to the netdev Mailing List.
 
 config STMMAC_PLATFORM
-	tristate "STMMAC Platform bus support"
+	tristate "STMMAC/DWMAC Platform bus support"
 	depends on STMMAC_ETH
 	select MFD_SYSCON
 	default y
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] net: stmmac: add Rockchip as supported platform in STMMAC_PLATFORM help text
  2020-06-26 12:05 [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC Johan Jonker
@ 2020-06-26 12:05 ` Johan Jonker
  2020-06-26 20:21 ` [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Johan Jonker @ 2020-06-26 12:05 UTC (permalink / raw)
  To: peppe.cavallaro
  Cc: alexandre.torgue, joabreu, davem, kuba, mcoquelin.stm32, heiko,
	linux-rockchip, netdev, linux-stm32, linux-arm-kernel,
	linux-kernel

The Kconfig menu has an option for DWMAC_ROCKCHIP.
Then add Rockchip also as supported platform in the help text
of STMMAC_PLATFORM.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
index 8f7625cc8..8309e05b4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
@@ -33,7 +33,7 @@ config STMMAC_PLATFORM
 	---help---
 	  This selects the platform specific bus support for the stmmac driver.
 	  This is the driver used on several SoCs:
-	  STi, Allwinner, Amlogic Meson, Altera SOCFPGA.
+	  STi, Allwinner, Amlogic Meson, Altera SOCFPGA, Rockchip.
 
 	  If you have a controller with this interface, say Y or M here.
 
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC
  2020-06-26 12:05 [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC Johan Jonker
  2020-06-26 12:05 ` [PATCH 2/2] net: stmmac: add Rockchip as supported platform in STMMAC_PLATFORM help text Johan Jonker
@ 2020-06-26 20:21 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-06-26 20:21 UTC (permalink / raw)
  To: jbx6244
  Cc: peppe.cavallaro, alexandre.torgue, joabreu, kuba,
	mcoquelin.stm32, heiko, linux-rockchip, netdev, linux-stm32,
	linux-arm-kernel, linux-kernel

From: Johan Jonker <jbx6244@gmail.com>
Date: Fri, 26 Jun 2020 14:05:26 +0200

> When a Rockchip user wants to enable support for
> the ethernet controller one has to search for
> something with STMicroelectronics.
> Change the Kconfig menu entry to STMMAC/DWMAC,
> so that it better reflects the options it enables.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

I'm not OK with this.  It's called internally stmmac
beause it's based upon an ST Microelectronics chipset.

This is what happens when we have several sub drivers
based upon a top-level common chipset "library".

The problem you have is that just knowing the driver
doesn't tell you the dependencies, but that's a larger
scope generic problem that needs a high level solution
rather then something we should be hacking around with
name adjustments here and there.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-26 20:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-26 12:05 [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC Johan Jonker
2020-06-26 12:05 ` [PATCH 2/2] net: stmmac: add Rockchip as supported platform in STMMAC_PLATFORM help text Johan Jonker
2020-06-26 20:21 ` [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).