From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3940C433E0 for ; Fri, 26 Jun 2020 15:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3C092075D for ; Fri, 26 Jun 2020 15:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="t3JMremr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730152AbgFZPyG (ORCPT ); Fri, 26 Jun 2020 11:54:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730103AbgFZPxv (ORCPT ); Fri, 26 Jun 2020 11:53:51 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB329C08C5DB for ; Fri, 26 Jun 2020 08:53:51 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f7so6985714wrw.1 for ; Fri, 26 Jun 2020 08:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I4rpaOEGU6H+oYaNchZTaDtgcXUEdwPMz6PwjmYhQuA=; b=t3JMremrEHYbvu8BWYRK5vIXUxE7NMD4JrgWG6ddzHCCR/Z3LNlDptd8V+Fbub+A+S iXVjVjSe/pCf5Xeu+SptMbyMDnb9ass5HOl+fM9eNteh3VAjIUJflJWSa6gtaR8B51yJ dk9PZM4BCwoA6Tf2ZcpyQ97nX8Kf2Ry9bd3EAzeKWoBA2NltjBpDe8IgTrYITmoMrdmq An9iV7f06x6Vyno0SIDq3B+tYCXZKlD+KAQThmj+Wzm1vxS37bfyTl9D9hsExxufvyic YiBV52DuK2i356Rh+1i2qSpF0vlDlSQwfFFk6T5JAfU58MWl3fSiwZ5x5chvkl25wNJG /7kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I4rpaOEGU6H+oYaNchZTaDtgcXUEdwPMz6PwjmYhQuA=; b=lruCwdzk4Yj+d6WPu8Zil/8qJBt/bal8yKNszwiLvgtXuI/3hRS5a+joqur0S90gkv jsHIG/mcfg4qHJTlvMT/IbzBDmYxI80BvqRSlsm+jOB5qWQRQljS6imRR8EerzZOeEcF 7R+F+4oTIdToKw5TxuXsm6xEOAJTkuI84JaViGm0b5Nzit4jA53oIkQj5YWbhisICmJc 42L7ifPHGZL6mEsObsKwW5tQsxL8GkHRXiPxfv5HtuIhyuahQ6DrBtqaQTlIYyMO5LRz VNYNT9jk9chAYSIS0OdoS78DVq+1ixxzt4P0SpB9nIoEWl3+4lL333jGLdDMmKs+fxpp EuRw== X-Gm-Message-State: AOAM532awPgTVT1aL1QoRwh5x+z+0CmWtHqQFYJMlTMO7QNtLdT26o1b qOltbFk8InS/O9tj3bVySIsxRQ== X-Google-Smtp-Source: ABdhPJyqd5lvQd8IxdSMeRr2YLPH2b3Xm3m/mqtt1qy7XUpRz0ceuuRrZdLdo+dF7vLdHK3c//jh2Q== X-Received: by 2002:a5d:4107:: with SMTP id l7mr4681479wrp.144.1593186830627; Fri, 26 Jun 2020 08:53:50 -0700 (PDT) Received: from localhost.localdomain (lfbn-nic-1-65-232.w2-15.abo.wanadoo.fr. [2.15.156.232]) by smtp.gmail.com with ESMTPSA id h142sm8242791wme.3.2020.06.26.08.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 08:53:50 -0700 (PDT) From: Bartosz Golaszewski To: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , Philipp Zabel Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 6/6] net: phy: mdio: reset MDIO devices even if probe() is not implemented Date: Fri, 26 Jun 2020 17:53:25 +0200 Message-Id: <20200626155325.7021-7-brgl@bgdev.pl> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200626155325.7021-1-brgl@bgdev.pl> References: <20200626155325.7021-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Similarily to PHY drivers - there's no reason to require probe() to be implemented in order to call mdio_device_reset(). MDIO devices can have resets defined without needing to do anything in probe(). Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Lunn --- drivers/net/phy/mdio_device.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index f60443e48622..be615504b829 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -150,10 +150,10 @@ static int mdio_probe(struct device *dev) struct mdio_driver *mdiodrv = to_mdio_driver(drv); int err = 0; - if (mdiodrv->probe) { - /* Deassert the reset signal */ - mdio_device_reset(mdiodev, 0); + /* Deassert the reset signal */ + mdio_device_reset(mdiodev, 0); + if (mdiodrv->probe) { err = mdiodrv->probe(mdiodev); if (err) { /* Assert the reset signal */ @@ -170,12 +170,11 @@ static int mdio_remove(struct device *dev) struct device_driver *drv = mdiodev->dev.driver; struct mdio_driver *mdiodrv = to_mdio_driver(drv); - if (mdiodrv->remove) { + if (mdiodrv->remove) mdiodrv->remove(mdiodev); - /* Assert the reset signal */ - mdio_device_reset(mdiodev, 1); - } + /* Assert the reset signal */ + mdio_device_reset(mdiodev, 1); return 0; } -- 2.26.1