Re: [PATCH] ARM: dts: imx53: ppd: alarm LEDs use kernel LED interface

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, Ian Ray <ian.ray@ge.com>,
	Samu Nuutamo <samu.nuutamo@vincit.fi>
Subject: Re: [PATCH] ARM: dts: imx53: ppd: alarm LEDs use kernel LED interface
Date: Fri, 26 Jun 2020 18:35:11 +0200	[thread overview]
Message-ID: <20200626163511.ecblnjw6ckh77kog@earth.universe> (raw)
In-Reply-To: <20200416145123.73039-1-sebastian.reichel@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 3001 bytes --]

Hi,

Can this be applied please? There were no changes in 5.8 cycle to
PPD's DT file, so it still applies.

Thanks,

-- Sebastian

On Thu, Apr 16, 2020 at 04:51:23PM +0200, Sebastian Reichel wrote:
> From: Ian Ray <ian.ray@ge.com>
> 
> Use kernel LED interface for the alarm LEDs.
> 
> Signed-off-by: Ian Ray <ian.ray@ge.com>
> [Rebased]
> Signed-off-by: Samu Nuutamo <samu.nuutamo@vincit.fi>
> [Rebased]
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  arch/arm/boot/dts/imx53-ppd.dts | 49 +++++++++++++++++++++++++++------
>  1 file changed, 40 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
> index 5ff9a179c83c..34ce41600098 100644
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -176,7 +176,7 @@ pwm_bl: backlight {
>  		power-supply = <&reg_3v3_lcd>;
>  	};
>  
> -	leds {
> +	leds-brightness {
>  		compatible = "pwm-leds";
>  
>  		alarm-brightness {
> @@ -185,6 +185,32 @@ alarm-brightness {
>  		};
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_alarmled_pins>;
> +
> +		alarm1 {
> +			label = "alarm:red";
> +			gpios = <&gpio7 3 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		alarm2 {
> +			label = "alarm:yellow";
> +			gpios = <&gpio7 7 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		alarm3 {
> +			label = "alarm:blue";
> +			gpios = <&gpio7 8 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		alarm4 {
> +			label = "alarm:silenced";
> +			gpios = <&gpio7 13 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
>  	gpio-poweroff {
>  		compatible = "gpio-poweroff";
>  		gpios = <&gpio3 9 GPIO_ACTIVE_HIGH>;
> @@ -909,18 +935,10 @@ MX53_PAD_NANDF_CS2__GPIO6_15		0x0
>  			MX53_PAD_NANDF_CS3__GPIO6_16		0x0
>  			/* POWER_AND_BOOT_STATUS_INDICATOR */
>  			MX53_PAD_PATA_INTRQ__GPIO7_2		0x1e4
> -			/* ACTIVATE_ALARM_LIGHT_RED */
> -			MX53_PAD_PATA_DIOR__GPIO7_3		0x0
> -			/* ACTIVATE_ALARM_LIGHT_YELLOW */
> -			MX53_PAD_PATA_DA_1__GPIO7_7		0x0
> -			/* ACTIVATE_ALARM_LIGHT_CYAN */
> -			MX53_PAD_PATA_DA_2__GPIO7_8		0x0
>  			/* RUNNING_ON_BATTERY_INDICATOR_GREEN */
>  			MX53_PAD_GPIO_16__GPIO7_11		0x0
>  			/* BATTERY_STATUS_INDICATOR_AMBER */
>  			MX53_PAD_GPIO_17__GPIO7_12		0x0
> -			/* AUDIO_ALARMS_SILENCED_INDICATOR */
> -			MX53_PAD_GPIO_18__GPIO7_13		0x0
>  		>;
>  	};
>  
> @@ -1080,4 +1098,17 @@ pinctrl_usb_otg: usbotggrp {
>  			MX53_PAD_KEY_COL4__USBOH3_USBOTG_OC	0x180
>  		>;
>  	};
> +
> +	pinctrl_alarmled_pins: qmx6alarmledgrp {
> +		fsl,pins = <
> +			/* ACTIVATE_ALARM_LIGHT_RED */
> +			MX53_PAD_PATA_DIOR__GPIO7_3		0x0
> +			/* ACTIVATE_ALARM_LIGHT_YELLOW */
> +			MX53_PAD_PATA_DA_1__GPIO7_7		0x0
> +			/* ACTIVATE_ALARM_LIGHT_CYAN */
> +			MX53_PAD_PATA_DA_2__GPIO7_8		0x0
> +			/* AUDIO_ALARMS_SILENCED_INDICATOR */
> +			MX53_PAD_GPIO_18__GPIO7_13		0x0
> +		>;
> +	};
>  };
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]