From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels
Date: Sun, 28 Jun 2020 10:53:30 +0200 [thread overview]
Message-ID: <20200628085330.GA132428@ravnborg.org> (raw)
In-Reply-To: <20200628080253.GD6954@pendragon.ideasonboard.com>
On Sun, Jun 28, 2020 at 11:02:53AM +0300, Laurent Pinchart wrote:
> Hi Sam,
>
> > We should also clean up all the DRM_BUS_FLAG_* one day.
> > No need for the deprecated values, so a few files needs an update.
> > And we could document what flags makes sense for LVDS etc.
>
> Where would you add that documentation ? The hardest part is to find a
> place that will be noticed by developers :-)
I will try to extend drm_bus_flags documentation in drm_connector.h
And then add a few comments in panel-simple as well.
Sam
>
> I've just submitted a patch that adds a WARN_ON to catch similar issues
> in the panel-simple driver. It's not ideal as we really shouldn't have
> such code in the kernel, this is something that should be caught as part
> of the integration process.
>
> > On the TODO list...
> >
> > >>> The rest looks good, except the Samsung panel for which I haven't been
> > >>> able to locate a datasheet.
> > >>>
> > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2020-06-28 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 22:27 [PATCH v1 0/2] Improve descriptions of a few simple-panels Dmitry Osipenko
2020-06-21 22:27 ` [PATCH v1 1/2] drm/panel-simple: Correct EDT ET057090DHU connector type Dmitry Osipenko
2020-06-21 22:29 ` Laurent Pinchart
2020-06-22 13:40 ` Dmitry Osipenko
2020-06-21 22:27 ` [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels Dmitry Osipenko
2020-06-27 20:43 ` Laurent Pinchart
2020-06-27 23:44 ` Dmitry Osipenko
2020-06-28 7:07 ` Laurent Pinchart
2020-06-28 7:52 ` Sam Ravnborg
2020-06-28 8:02 ` Laurent Pinchart
2020-06-28 8:53 ` Sam Ravnborg [this message]
2020-06-27 20:19 ` [PATCH v1 0/2] Improve descriptions of a few simple-panels Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200628085330.GA132428@ravnborg.org \
--to=sam@ravnborg.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).