From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99EEC433E0 for ; Mon, 29 Jun 2020 19:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B34E120672 for ; Mon, 29 Jun 2020 19:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593459406; bh=yzF+R1vfR4+sPC1JW0ON7fOehKKTbTlT2m6gPB/YGc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PF2UEJ5K1VukwLEnisf9SG+uX1mgR1MNpGQnrXKma4psHcVRiNuIlC5VbwHjCe0sy EUEQp6CV9wmp7Hrg1jZfHh28yH/WUfMJbFU9Q7Me1VOkax3LRVBqq1V3pJqrytanIJ EGfh+IdrMUFsTLAWzldQA6Vl2hTG7Y67O/secIFo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733089AbgF2Tgp (ORCPT ); Mon, 29 Jun 2020 15:36:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:40592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733021AbgF2Tae (ORCPT ); Mon, 29 Jun 2020 15:30:34 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF9BB251E7; Mon, 29 Jun 2020 15:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593444906; bh=yzF+R1vfR4+sPC1JW0ON7fOehKKTbTlT2m6gPB/YGc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fO+KDijP+GdZ2zRCdorym8JKgge2OWrA7clnsc1yVQXvcB8vuH/xdj0b9KPVloRfc iIzvHv3SBhZmdHVSUQ0pQFm0A6xrVG9OP/eLeMJLrEQWo1L3QEnH2pAkqcPJ4jNNlO Qyvy6x3g98eCYZ2qQdNsMaCWXCjYGUFMASd3bFks= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: yu kuai , Ming Lei , Bob Liu , "Martin K . Petersen" , Jens Axboe , Guenter Roeck , Greg Kroah-Hartman Subject: [PATCH 4.19 002/131] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed Date: Mon, 29 Jun 2020 11:32:53 -0400 Message-Id: <20200629153502.2494656-3-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629153502.2494656-1-sashal@kernel.org> References: <20200629153502.2494656-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.131-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.19.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.19.131-rc1 X-KernelTest-Deadline: 2020-07-01T15:34+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: yu kuai commit a75ca9303175d36af93c0937dd9b1a6422908b8d upstream. commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") added a kfree() for 'buf' if bio_integrity_add_page() returns '0'. However, the object will be freed in bio_integrity_free() since 'bio->bi_opf' and 'bio->bi_integrity' were set previousy in bio_integrity_alloc(). Fixes: commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") Signed-off-by: yu kuai Reviewed-by: Ming Lei Reviewed-by: Bob Liu Acked-by: Martin K. Petersen Signed-off-by: Jens Axboe Cc: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- block/bio-integrity.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/bio-integrity.c b/block/bio-integrity.c index 5bd90cd4b51e3..a059fad53f1b0 100644 --- a/block/bio-integrity.c +++ b/block/bio-integrity.c @@ -293,7 +293,6 @@ bool bio_integrity_prep(struct bio *bio) if (ret == 0) { printk(KERN_ERR "could not attach integrity payload\n"); - kfree(buf); status = BLK_STS_RESOURCE; goto err_end_io; } -- 2.25.1