From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA00CC433E1 for ; Mon, 29 Jun 2020 19:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A5EB206E2 for ; Mon, 29 Jun 2020 19:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593457982; bh=V+ahR2kIEDOuEOMyidmVqcY3UmUtoO3I0e5fiMrHOQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HDBCc8u74iwT6EsPeSxm1zNz3Pvjw4bfemUww5rCE7n1eIpVneH19A7llqnfyeZf/ 0padOMjwr+zINlwC8N/UYfWlj7IEQ0D8xjAsUgXy8EioF+bIdKi+sTD7uQwL4BmHrl xrI1954oqNMYbspOpyPLcWDaYPCTe100BeImCMgE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726065AbgF2TNA (ORCPT ); Mon, 29 Jun 2020 15:13:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:53790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730969AbgF2TKS (ORCPT ); Mon, 29 Jun 2020 15:10:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A2CBD254B1; Mon, 29 Jun 2020 15:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593446008; bh=V+ahR2kIEDOuEOMyidmVqcY3UmUtoO3I0e5fiMrHOQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O0gq11+zL0BEd+L0RgvaJ3A2ekRFUg44YpLbv5I7n2lQueRK/BlAuJZIO+IofMgcR xu2MiI1VpoiF8ZRQoJF3HMy9UPTsbVVpLeu/rH6YQpb5V6W5mnphAF5XzrPnFaKTQD xmqKIP990mr3ii8gTjcLfAANFrIm6oXvF7ZQ7jJg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wang Hai , Hulk Robot , "David S . Miller" , Sasha Levin Subject: [PATCH 4.4 015/135] yam: fix possible memory leak in yam_init_driver Date: Mon, 29 Jun 2020 11:51:09 -0400 Message-Id: <20200629155309.2495516-16-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629155309.2495516-1-sashal@kernel.org> References: <20200629155309.2495516-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.4.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:53+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang Hai [ Upstream commit 98749b7188affbf2900c2aab704a8853901d1139 ] If register_netdev(dev) fails, free_netdev(dev) needs to be called, otherwise a memory leak will occur. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hamradio/yam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 1a4729c36aa49..623e4225e7c84 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1160,6 +1160,7 @@ static int __init yam_init_driver(void) err = register_netdev(dev); if (err) { printk(KERN_WARNING "yam: cannot register net device %s\n", dev->name); + free_netdev(dev); goto error; } yam_devs[i] = dev; -- 2.25.1