From: David Miller <davem@davemloft.net>
To: natechancellor@gmail.com
Cc: kuba@kernel.org, vaibhavgupta40@gmail.com, pcnet32@frontier.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] pcnet32: Mark PM functions as __maybe_unused
Date: Tue, 30 Jun 2020 18:18:18 -0700 (PDT) [thread overview]
Message-ID: <20200630.181818.960616348417321292.davem@davemloft.net> (raw)
In-Reply-To: <20200630210034.3624587-2-natechancellor@gmail.com>
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Tue, 30 Jun 2020 14:00:34 -0700
> In certain configurations without power management support, the
> following warnings happen:
>
> ../drivers/net/ethernet/amd/pcnet32.c:2928:12: warning:
> 'pcnet32_pm_resume' defined but not used [-Wunused-function]
> 2928 | static int pcnet32_pm_resume(struct device *device_d)
> | ^~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/amd/pcnet32.c:2916:12: warning:
> 'pcnet32_pm_suspend' defined but not used [-Wunused-function]
> 2916 | static int pcnet32_pm_suspend(struct device *device_d)
> | ^~~~~~~~~~~~~~~~~~
>
> Mark these functions as __maybe_unused to make it clear to the compiler
> that this is going to happen based on the configuration, which is the
> standard for these types of functions.
>
> Fixes: a86688fbef1b ("pcnet32: Convert to generic power management")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied.
next prev parent reply other threads:[~2020-07-01 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 21:00 [PATCH net-next 1/2] amd8111e: Mark PM functions as __maybe_unused Nathan Chancellor
2020-06-30 21:00 ` [PATCH net-next 2/2] pcnet32: " Nathan Chancellor
2020-07-01 1:18 ` David Miller [this message]
2020-07-01 1:18 ` [PATCH net-next 1/2] amd8111e: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630.181818.960616348417321292.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@frontier.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).