From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55665C433E2 for ; Tue, 30 Jun 2020 03:06:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C9A320748 for ; Tue, 30 Jun 2020 03:06:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="szix04EN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbgF3DF6 (ORCPT ); Mon, 29 Jun 2020 23:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728880AbgF3DF4 (ORCPT ); Mon, 29 Jun 2020 23:05:56 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44068C03E97A for ; Mon, 29 Jun 2020 20:05:55 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id x11so7882131plo.7 for ; Mon, 29 Jun 2020 20:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cNEVQy+vICiaQ3dEMjEVUMkRw1CNp3UqW6ADGZMeyq0=; b=szix04ENS8s/vNMuSV9gmxw6eDA/gHtPJCmi32AKDZtmQTu3dznzhrEYphazqsUTuV SD1LuvDvVW4PVhTqNQR0lQ8s/bE0fcLUu7dY1F+4WnisN/0UIb6GE1KSfXBiM+j9ft7q 3iBqr8MxTD6kVSOBAVKm7ROP5aQqjOLPul/cWyg6+21Z5+UFZU571T26GNGiF3nYrcef wtJU0UjEtuJI9OtB7V78h+IZIMC48jFdlYemLhceDJ8QUmUGJL+kxfIUgAFPz+omWvMn 7fQszesv9mXKkojzECfYvnGnx0N2NU2b1Cj0u94tyqer7SKrGU4IIREFN0OHnge5CFUJ zE9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cNEVQy+vICiaQ3dEMjEVUMkRw1CNp3UqW6ADGZMeyq0=; b=Vi3kIDIWgOaXwCzy7UvIJZS25YfGeEbCiCrc/IoeUXDDwUucdCe8Aubbr1xdJAe8Kn sUYmY+MUTAZeF7yK7LLdprVWGUZV5yZ6qW3FiXyH6wmGaMjp7Jog50nayWR8iKv0ONHM HWvpnP5OlOsNp6qzDtvqmBwrF7o+nnGlnwJu9z2U9btu0g0bG4x6UQlDSSlMg/7dumIp G4yl9qaZVmxCsQ5JLGcTnvPGO+xdb9X9rTnQVaewNYplEBGRvU+N8in1Da3FDn9X4Zy8 lYIzUrlkAlQEF54FFDs7yecb6vI5GuTF97FKnipHzFmywpaxoC0NJDhDqEoqz3WwxUvY +DWA== X-Gm-Message-State: AOAM530iIwvD7SncAayrN5hVyAlE10t0zLpAYvX+tGaXYGS4Xz4eDFk+ JUJlhNZgl9A+lQjOThOyv45Yuw== X-Google-Smtp-Source: ABdhPJwwYS9W4O4PrjOlLGBl4/OdVWJfaqDpaTLMqlG01WLme1r8xY9RSXQUaUY08Gft6qu0rVWgxg== X-Received: by 2002:a17:90a:110:: with SMTP id b16mr7674307pjb.235.1593486354641; Mon, 29 Jun 2020 20:05:54 -0700 (PDT) Received: from localhost ([122.172.127.76]) by smtp.gmail.com with ESMTPSA id z2sm905277pfq.67.2020.06.29.20.05.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2020 20:05:54 -0700 (PDT) Date: Tue, 30 Jun 2020 08:35:52 +0530 From: Viresh Kumar To: Stephen Boyd , Rajendra Nayak Cc: agross@kernel.org, bjorn.andersson@linaro.org, robdclark@chromium.org, robdclark@gmail.com, stanimir.varbanov@linaro.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Akash Asthana , linux-serial@vger.kernel.org Subject: Re: [PATCH v6 1/6] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state Message-ID: <20200630030552.cfp5oh33qde6nlnf@vireshk-i7> References: <1592222564-13556-1-git-send-email-rnayak@codeaurora.org> <1592222564-13556-2-git-send-email-rnayak@codeaurora.org> <159347264530.1987609.11350620235820019545@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-06-20, 08:31, Rajendra Nayak wrote: > > > On 6/30/2020 4:47 AM, Stephen Boyd wrote: > > Quoting Rajendra Nayak (2020-06-15 05:02:39) > > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > > > index 457c0bf..a90f8ec 100644 > > > --- a/drivers/tty/serial/qcom_geni_serial.c > > > +++ b/drivers/tty/serial/qcom_geni_serial.c > > > @@ -9,6 +9,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -962,7 +963,7 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport, > > > goto out_restart_rx; > > > uport->uartclk = clk_rate; > > > - clk_set_rate(port->se.clk, clk_rate); > > > + dev_pm_opp_set_rate(uport->dev, clk_rate); > > > > If there isn't an OPP table for the device because it is optional then > > how can we unconditionally call dev_pm_opp_set_rate()? Looks like some *Maintainers* aren't paying enough attention lately ;) Just kidding. > because we have 'aca48b6 opp: Manage empty OPP tables with clk handle' to handle this. -- viresh