* [PATCH net-next] net: dsa: Improve subordinate PHY error message
@ 2020-06-30 4:43 Florian Fainelli
2020-06-30 14:19 ` Andrew Lunn
2020-06-30 19:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-06-30 4:43 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Andrew Lunn, Vivien Didelot, David S. Miller,
Jakub Kicinski, open list
It is not very informative to know the DSA master device when a
subordinate network device fails to get its PHY setup. Provide the
device name and capitalize PHY while we are it.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
net/dsa/slave.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 4c7f086a047b..e147e10b411c 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1795,7 +1795,8 @@ int dsa_slave_create(struct dsa_port *port)
ret = dsa_slave_phy_setup(slave_dev);
if (ret) {
- netdev_err(master, "error %d setting up slave phy\n", ret);
+ netdev_err(master, "error %d setting up slave PHY for %s\n",
+ ret, slave_dev->name);
goto out_gcells;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: Improve subordinate PHY error message
2020-06-30 4:43 [PATCH net-next] net: dsa: Improve subordinate PHY error message Florian Fainelli
@ 2020-06-30 14:19 ` Andrew Lunn
2020-06-30 19:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-06-30 14:19 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Vivien Didelot, David S. Miller, Jakub Kicinski, open list
On Mon, Jun 29, 2020 at 09:43:13PM -0700, Florian Fainelli wrote:
> It is not very informative to know the DSA master device when a
> subordinate network device fails to get its PHY setup. Provide the
> device name and capitalize PHY while we are it.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: Improve subordinate PHY error message
2020-06-30 4:43 [PATCH net-next] net: dsa: Improve subordinate PHY error message Florian Fainelli
2020-06-30 14:19 ` Andrew Lunn
@ 2020-06-30 19:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-06-30 19:52 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew, vivien.didelot, kuba, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 29 Jun 2020 21:43:13 -0700
> It is not very informative to know the DSA master device when a
> subordinate network device fails to get its PHY setup. Provide the
> device name and capitalize PHY while we are it.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-30 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 4:43 [PATCH net-next] net: dsa: Improve subordinate PHY error message Florian Fainelli
2020-06-30 14:19 ` Andrew Lunn
2020-06-30 19:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).