* [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver
@ 2020-06-30 4:45 David Gow
2020-07-11 16:30 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: David Gow @ 2020-06-30 4:45 UTC (permalink / raw)
To: Soren Brinkmann, Greg Kroah-Hartman, Stephen Boyd, Michael Turquette
Cc: linux-clk, devel, Brendan Higgins, linux-kernel, David Gow
The Xilinx Clocking Wizard driver uses the devm_ioremap_resource
function, but does not specify a dependency on IOMEM in Kconfig. This
causes a build failure on architectures without IOMEM, for example, UML
(notably with make allyesconfig).
Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.
Signed-off-by: David Gow <davidgow@google.com>
---
drivers/staging/clocking-wizard/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/clocking-wizard/Kconfig b/drivers/staging/clocking-wizard/Kconfig
index 04be22dca9b6..69cf51445f08 100644
--- a/drivers/staging/clocking-wizard/Kconfig
+++ b/drivers/staging/clocking-wizard/Kconfig
@@ -5,6 +5,6 @@
config COMMON_CLK_XLNX_CLKWZRD
tristate "Xilinx Clocking Wizard"
- depends on COMMON_CLK && OF
+ depends on COMMON_CLK && OF && IOMEM
help
Support for the Xilinx Clocking Wizard IP core clock generator.
--
2.27.0.212.ge8ba1cc988-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver
2020-06-30 4:45 [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver David Gow
@ 2020-07-11 16:30 ` Stephen Boyd
2020-07-12 6:49 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-07-11 16:30 UTC (permalink / raw)
To: David Gow, Greg Kroah-Hartman, Michael Turquette, Soren Brinkmann
Cc: linux-clk, devel, Brendan Higgins, linux-kernel, David Gow
Quoting David Gow (2020-06-29 21:45:17)
> The Xilinx Clocking Wizard driver uses the devm_ioremap_resource
> function, but does not specify a dependency on IOMEM in Kconfig. This
> causes a build failure on architectures without IOMEM, for example, UML
> (notably with make allyesconfig).
>
> Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.
>
> Signed-off-by: David Gow <davidgow@google.com>
> ---
This driver is in the process of being destaged to drivers/clk/
Greg, should I pick this one up?
> drivers/staging/clocking-wizard/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver
2020-07-11 16:30 ` Stephen Boyd
@ 2020-07-12 6:49 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-12 6:49 UTC (permalink / raw)
To: Stephen Boyd
Cc: David Gow, Michael Turquette, Soren Brinkmann, devel,
Brendan Higgins, linux-clk, linux-kernel
On Sat, Jul 11, 2020 at 09:30:10AM -0700, Stephen Boyd wrote:
> Quoting David Gow (2020-06-29 21:45:17)
> > The Xilinx Clocking Wizard driver uses the devm_ioremap_resource
> > function, but does not specify a dependency on IOMEM in Kconfig. This
> > causes a build failure on architectures without IOMEM, for example, UML
> > (notably with make allyesconfig).
> >
> > Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.
> >
> > Signed-off-by: David Gow <davidgow@google.com>
> > ---
>
> This driver is in the process of being destaged to drivers/clk/
>
> Greg, should I pick this one up?
Sure, if I haven't already.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-12 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 4:45 [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver David Gow
2020-07-11 16:30 ` Stephen Boyd
2020-07-12 6:49 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).