From: Will Deacon <will@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: "liwei (GF)" <liwei391@huawei.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jason Wessel <jason.wessel@windriver.com>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
David Miller <davem@davemloft.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
liwei1412@163.com
Subject: Re: [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues
Date: Tue, 30 Jun 2020 08:22:22 +0100 [thread overview]
Message-ID: <20200630072221.GA13332@willie-the-truck> (raw)
In-Reply-To: <CAD=FV=WYBAJB_nWxUAAVgV26e4CTzJeizZtxpwus6REi3j2meA@mail.gmail.com>
On Mon, Jun 29, 2020 at 02:20:11PM -0700, Doug Anderson wrote:
> On Sat, May 16, 2020 at 1:20 AM liwei (GF) <liwei391@huawei.com> wrote:
> > On 2020/5/14 8:34, Doug Anderson wrote:
> > > On Sat, May 9, 2020 at 6:49 AM Wei Li <liwei391@huawei.com> wrote:
> > >>
> > >> This patch set is to fix several issues of single-step debugging
> > >> in kgdb/kdb on arm64.
> > >>
> > >> It seems that these issues have been shelved a very long time,
> > >> but i still hope to solve them, as the single-step debugging
> > >> is an useful feature.
> > >>
> > >> Note:
> > >> Based on patch "arm64: cacheflush: Fix KGDB trap detection",
> > >> https://www.spinics.net/lists/arm-kernel/msg803741.html
> > >>
> > >> Wei Li (4):
> > >> arm64: kgdb: Fix single-step exception handling oops
> > >> arm64: Extract kprobes_save_local_irqflag() and
> > >> kprobes_restore_local_irqflag()
> > >> arm64: kgdb: Fix single-stepping into the irq handler wrongly
> > >> arm64: kgdb: Set PSTATE.SS to 1 to reenable single-step
> > >>
> > >> arch/arm64/include/asm/debug-monitors.h | 6 ++++++
> > >> arch/arm64/kernel/debug-monitors.c | 28 ++++++++++++++++++++++++-
> > >> arch/arm64/kernel/kgdb.c | 16 +++++++++++---
> > >> arch/arm64/kernel/probes/kprobes.c | 28 ++-----------------------
> > >> 4 files changed, 48 insertions(+), 30 deletions(-)
> > >
> > > Just an overall note that I'm very happy that you posted this patch
> > > series! It's always been a thorn in my side that stepping and
> > > breakpoints were so broken on arm64 and I'm really excited that you're
> > > fixing them. Now I'll have to get in the habit of using kgdb for more
> > > than just debugging crashes and maybe I can use it more for exploring
> > > how functions work more. :-)
> > > > I'll also note that with your patch series I'm even seeing the "call"
> > > feature of gdb working now. That has always been terribly broken for
> > > me.
> > >
> > Thanks for reviewing and testing this series.
> > Enjoy exploring the kernel with kgdb/kdb! :-)
>
> I'm curious to know if you plan another spin. The feedback you
> received was fairly minor so it hopefully shouldn't be too hard. I'd
> very much like to get your patches landed and I'd be happy to try to
> address the feedback and spin them myself if you're no longer
> available for it.
I'd welcome some feedback on the proposal I sent out at the end of last
week:
https://lore.kernel.org/r/20200626095551.GA9312@willie-the-truck
which looks to solve some (all?) of these issues slightly differently,
because it turns out we need to perform some low-level surgery for
preempt-rt *anyway*...
I'm particularly keen to hear any thoughts concerning the reschedule on
return to EL1 after handling an interrupt that hit during a step.
Will
next prev parent reply other threads:[~2020-06-30 7:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 21:41 [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues Wei Li
2020-05-09 21:41 ` [PATCH 1/4] arm64: kgdb: Fix single-step exception handling oops Wei Li
2020-05-14 0:21 ` Doug Anderson
2020-05-09 21:41 ` [PATCH 2/4] arm64: Extract kprobes_save_local_irqflag() and kprobes_restore_local_irqflag() Wei Li
2020-05-10 8:59 ` Masami Hiramatsu
2020-05-14 0:21 ` Doug Anderson
2020-05-16 8:47 ` liwei (GF)
2020-05-16 16:17 ` Doug Anderson
2020-05-18 15:14 ` Masami Hiramatsu
2020-05-09 21:41 ` [PATCH 3/4] arm64: kgdb: Fix single-stepping into the irq handler wrongly Wei Li
2020-05-14 0:21 ` Doug Anderson
2020-05-09 21:41 ` [PATCH 4/4] arm64: kgdb: Set PSTATE.SS to 1 to reenable single-step Wei Li
2020-05-14 0:23 ` Doug Anderson
2020-05-16 8:20 ` liwei (GF)
2020-05-14 0:34 ` [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues Doug Anderson
2020-05-16 8:20 ` liwei (GF)
2020-06-29 21:20 ` Doug Anderson
2020-06-30 7:22 ` Will Deacon [this message]
2020-07-06 21:37 ` Doug Anderson
2020-07-08 22:06 ` Will Deacon
2020-07-08 22:22 ` Doug Anderson
2020-07-07 1:37 ` liwei (GF)
2020-07-08 22:02 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630072221.GA13332@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei1412@163.com \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).