From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Gutson <daniel.gutson@eclypsium.com>
Cc: Derek Kiernan <derek.kiernan@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org,
Richard Hughes <hughsient@gmail.com>,
Alex Bazhaniuk <alex@eclypsium.com>
Subject: Re: [PATCH] SPI LPC information kernel module
Date: Tue, 30 Jun 2020 10:58:39 +0200 [thread overview]
Message-ID: <20200630085839.GE637809@kroah.com> (raw)
In-Reply-To: <20200629225932.5036-1-daniel.gutson@eclypsium.com>
On Mon, Jun 29, 2020 at 07:59:32PM -0300, Daniel Gutson wrote:
> --- /dev/null
> +++ b/drivers/misc/spi_lpc/bios_data_access.h
> @@ -0,0 +1,181 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * SPI LPC flash platform security driver
> + *
> + * Copyright 2020 (c) Daniel Gutson (daniel.gutson@eclypsium.com)
> + *
> + */
> +#ifndef BIOS_DATA_ACCESS_H
> +#define BIOS_DATA_ACCESS_H
What BIOS? Is this a UEFI thing? ACPI? Uboot? Fastboot?
> +
> +#include <linux/types.h>
> +
> +enum PCH_Arch {
Why the upper-case name?
> + pch_none,
> + pch_6_c200,
> + pch_7_c210,
> + pch_c60x_x79,
> + pch_communications_89xx,
> + pch_8_c220,
> + pch_c61x_x99,
> + pch_5_mobile,
> + pch_6_mobile,
> + pch_7_8_mobile,
> + pch_1xx,
> + pch_c620,
> + pch_2xx,
> + pch_3xx,
> + pch_4xx,
> + pch_495,
> + pch_5xx,
> + PCH_Archs_count
Do these have real values that the hardware expects? If so, you need to
assign them numbers, right? If not, what do all of these mean?
> +};
> +
> +enum CPU_Arch {
> + cpu_none,
> + cpu_bdw,
> + cpu_bdx,
> + cpu_hsw,
> + cpu_hsx,
> + cpu_ivt,
> + cpu_jkt,
> + cpu_kbl,
> + cpu_skl,
> + cpu_ivb,
> + cpu_snb,
> + cpu_avn,
> + cpu_cfl,
> + cpu_byt,
> + cpu_whl,
> + cpu_cml,
> + cpu_icl,
> + cpu_apl,
> + cpu_glk,
> + cpu_tgl,
> + cpu_amd,
> + CPU_Archs_count
> +};
> +
> +enum RegisterSource { RegSource_PCH, RegSource_CPU };
Again all of the Caps, please don't use, that's not Linux styles (and
checkpatch.pl should have warned you about this, did you run it on your
patch?)
thanks,
greg k-h
next prev parent reply other threads:[~2020-06-30 8:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 22:59 [PATCH] SPI LPC information kernel module Daniel Gutson
2020-06-30 8:02 ` kernel test robot
2020-06-30 8:56 ` Greg Kroah-Hartman
2020-06-30 13:57 ` Richard Hughes
2020-06-30 14:24 ` Arnd Bergmann
2020-06-30 15:14 ` Greg Kroah-Hartman
[not found] ` <CAFmMkTGrnZt7ZaGyYCe-LCHET4yHz9DfanaZwsOS6HCxK40apQ@mail.gmail.com>
2020-06-30 15:00 ` Arnd Bergmann
2020-06-30 15:28 ` Greg Kroah-Hartman
2020-06-30 15:32 ` Greg Kroah-Hartman
[not found] ` <CAFmMkTGy7u8oNSPmBHf9+URzKeNOxy5TJtqF3FCruRkTgJ_wGQ@mail.gmail.com>
2020-06-30 16:55 ` Greg Kroah-Hartman
2020-06-30 8:58 ` Arnd Bergmann
[not found] ` <CAFmMkTHrQ4LZk4+-3kdJ+dc47MXR1Jd76AXbO-ceT2zsfDRFGQ@mail.gmail.com>
2020-06-30 20:57 ` Arnd Bergmann
[not found] ` <CAFmMkTE3z6OZQ_v3jx-4MzMr8v+4qcF2uLn0ASGydj5oqDnfjg@mail.gmail.com>
2020-07-06 9:20 ` Arnd Bergmann
2020-07-06 9:54 ` Arnd Bergmann
[not found] ` <CAFmMkTGkmBgmv6wmS1kNWxGm0ktN56u9pJVJQKyPvLipyHsgqw@mail.gmail.com>
2020-07-14 6:38 ` Greg Kroah-Hartman
2020-07-06 10:22 ` Arnd Bergmann
2020-06-30 8:58 ` Greg Kroah-Hartman [this message]
2020-06-30 8:59 ` Greg Kroah-Hartman
2020-06-30 9:00 ` Greg Kroah-Hartman
2020-07-01 7:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630085839.GE637809@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex@eclypsium.com \
--cc=arnd@arndb.de \
--cc=daniel.gutson@eclypsium.com \
--cc=derek.kiernan@xilinx.com \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).