From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C4FC433E0 for ; Tue, 30 Jun 2020 13:25:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DA64206C0 for ; Tue, 30 Jun 2020 13:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731691AbgF3NZV (ORCPT ); Tue, 30 Jun 2020 09:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730381AbgF3NZO (ORCPT ); Tue, 30 Jun 2020 09:25:14 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A402C061755; Tue, 30 Jun 2020 06:25:13 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGG4-002oEt-RX; Tue, 30 Jun 2020 13:25:08 +0000 Date: Tue, 30 Jun 2020 14:25:08 +0100 From: Al Viro To: Linus Torvalds Cc: linux-arch , Linux Kernel Mailing List , David Miller , Tony Luck , Will Deacon Subject: Re: [PATCH 18/41] regset: new method and helpers for it Message-ID: <20200630132508.GF2786714@ZenIV.linux.org.uk> References: <20200629182349.GA2786714@ZenIV.linux.org.uk> <20200629182628.529995-1-viro@ZenIV.linux.org.uk> <20200629182628.529995-18-viro@ZenIV.linux.org.uk> <20200629203028.GB2786714@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200629203028.GB2786714@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 09:30:28PM +0100, Al Viro wrote: > > (b) or just call it something better to begin with. Maybe just > > "get_regset" instead? > > > > Frankly, other field names there are also nasty - 'set' is not > fun to grep for, but there are 'n' and 'size' as well. There's > also 'bias' and 'align' (both completely unused)... How about ->regset_get()? I've force-pushed a variant with that change + removal of leftover unused variables (caught by Intel build bot) + braino fix in sparc conversion (spotted when looking through the patchset again); same branch names. Not sure if it's worth a repost of the entire patchbomb...