From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4D5C433E0 for ; Tue, 30 Jun 2020 13:34:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EA3C2074D for ; Tue, 30 Jun 2020 13:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388237AbgF3NeV (ORCPT ); Tue, 30 Jun 2020 09:34:21 -0400 Received: from verein.lst.de ([213.95.11.211]:35994 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388190AbgF3NeC (ORCPT ); Tue, 30 Jun 2020 09:34:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 21A1A68B05; Tue, 30 Jun 2020 15:33:59 +0200 (CEST) Date: Tue, 30 Jun 2020 15:33:58 +0200 From: Christoph Hellwig To: Maximilian Heyne Cc: Amit Shah , stable@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: validate cntlid's only for nvme >= 1.1.0 Message-ID: <20200630133358.GA20602@lst.de> References: <20200630122923.70282-1-mheyne@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200630122923.70282-1-mheyne@amazon.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2020 at 12:29:23PM +0000, Maximilian Heyne wrote: > Controller ID's (cntlid) for NVMe devices were introduced in version > 1.1.0 of the specification. Controllers that follow the older 1.0.0 spec > don't set this field so it doesn't make sense to validate it. On the > contrary, when using SR-IOV this check breaks VFs as they are all part > of the same NVMe subsystem. > > Signed-off-by: Maximilian Heyne > Cc: # 5.4+ The first hunk looks ok, the second doesn't make sense as fabrics was only added with NVMe 1.2.2. I can fix it up when applying if you are ok with that. But you guys really shouldn't be doing SR-IOV with 1.0 controllers independent of this..