From: Daniel Winkler <danielwinkler@google.com>
To: linux-serial@vger.kernel.org, linux-mediatek@lists.infradead.org
Cc: chromeos-bluetooth-upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
Daniel Winkler <danielwinkler@google.com>,
Aaron Sierra <asierra@xes-inc.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Lukas Wunner <lukas@wunner.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Revert "serial: 8250: Fix max baud limit in generic 8250 port"
Date: Tue, 30 Jun 2020 16:42:11 -0700 [thread overview]
Message-ID: <20200630164204.1.I2cc415fa5793b3e55acfd521ba8f0a71e79aa5f1@changeid> (raw)
This reverts commit 0eeaf62981ecc79e8395ca8caa1570eaf3a12257.
The change regresses the QCA6174A-3 bluetooth chip, preventing
firmware from being properly loaded. We have verified that without
this patch, the chip works as intended.
Signed-off-by: Daniel Winkler <danielwinkler@google.com>
---
drivers/tty/serial/8250/8250_port.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 1632f7d25acca..e057c65ac1580 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -2618,8 +2618,6 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port,
struct ktermios *termios,
struct ktermios *old)
{
- unsigned int tolerance = port->uartclk / 100;
-
/*
* Ask the core to calculate the divisor for us.
* Allow 1% tolerance at the upper limit so uart clks marginally
@@ -2628,7 +2626,7 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port,
*/
return uart_get_baud_rate(port, termios, old,
port->uartclk / 16 / UART_DIV_MAX,
- (port->uartclk + tolerance) / 16);
+ port->uartclk);
}
void
--
2.27.0.212.ge8ba1cc988-goog
next reply other threads:[~2020-06-30 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 23:42 Daniel Winkler [this message]
2020-07-01 4:30 ` [PATCH] Revert "serial: 8250: Fix max baud limit in generic 8250 port" Lukas Wunner
2020-07-01 11:39 ` Serge Semin
2020-07-01 12:46 ` Alain Michaud
2020-07-01 13:26 ` Greg Kroah-Hartman
2020-07-01 18:26 ` Daniel Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630164204.1.I2cc415fa5793b3e55acfd521ba8f0a71e79aa5f1@changeid \
--to=danielwinkler@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=asierra@xes-inc.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).