From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/uaccess: Use flexible addressing with __put_user()/__get_user()
Date: Tue, 30 Jun 2020 16:18:17 -0500 [thread overview]
Message-ID: <20200630211817.GZ3598@gate.crashing.org> (raw)
In-Reply-To: <f8819fa4-94e3-4bf9-4b60-c57d2804e529@csgroup.eu>
Hi again,
Thanks for your work so far!
On Tue, Jun 30, 2020 at 06:53:39PM +0000, Christophe Leroy wrote:
> On 06/30/2020 04:33 PM, Segher Boessenkool wrote:
> >>>+ make -s CC=powerpc64-linux-gnu-gcc -j 160
> >>>In file included from /linux/include/linux/uaccess.h:11:0,
> >>> from /linux/include/linux/sched/task.h:11,
> >>> from /linux/include/linux/sched/signal.h:9,
> >>> from /linux/include/linux/rcuwait.h:6,
> >>> from /linux/include/linux/percpu-rwsem.h:7,
> >>> from /linux/include/linux/fs.h:33,
> >>> from /linux/include/linux/huge_mm.h:8,
> >>> from /linux/include/linux/mm.h:675,
> >>> from /linux/arch/powerpc/kernel/signal_32.c:17:
> >>>/linux/arch/powerpc/kernel/signal_32.c: In function
> >>>'save_user_regs.isra.14.constprop':
> >>>/linux/arch/powerpc/include/asm/uaccess.h:161:2: error: 'asm' operand has
> >>>impossible constraints
> >>> __asm__ __volatile__( \
> >>> ^
> >>>/linux/arch/powerpc/include/asm/uaccess.h:197:12: note: in expansion of
> >>>macro '__put_user_asm'
> >>> case 4: __put_user_asm(x, ptr, retval, "stw"); break; \
> >>> ^
> >>>/linux/arch/powerpc/include/asm/uaccess.h:206:2: note: in expansion of
> >>>macro '__put_user_size_allowed'
> >>> __put_user_size_allowed(x, ptr, size, retval); \
> >>> ^
> >>>/linux/arch/powerpc/include/asm/uaccess.h:220:2: note: in expansion of
> >>>macro '__put_user_size'
> >>> __put_user_size(__pu_val, __pu_addr, __pu_size, __pu_err); \
> >>> ^
> >>>/linux/arch/powerpc/include/asm/uaccess.h:96:2: note: in expansion of
> >>>macro '__put_user_nocheck'
> >>> __put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
> >>> ^
> >>>/linux/arch/powerpc/kernel/signal_32.c:120:7: note: in expansion of macro
> >>>'__put_user'
> >>> if (__put_user((unsigned int)gregs[i], &frame->mc_gregs[i]))
> >>> ^
> >
> >Can we see what that was after the macro jungle? Like, the actual
> >preprocessed code?
>
> Sorry for previous misunderstanding
>
> Here is the code:
>
> #define __put_user_asm(x, addr, err, op) \
> __asm__ __volatile__( \
> "1: " op "%U2%X2 %1,%2 # put_user\n" \
> "2:\n" \
> ".section .fixup,\"ax\"\n" \
> "3: li %0,%3\n" \
> " b 2b\n" \
> ".previous\n" \
> EX_TABLE(1b, 3b) \
> : "=r" (err) \
> : "r" (x), "m<>" (*addr), "i" (-EFAULT), "0" (err))
Yeah I don't see it. I'll have to look at compiler debug dumps, but I
don't have any working 4.9 around, and I cannot reproduce this with
either older or newer compilers.
It is complainig that constrain_operands just does not work *at all* on
this "m<>" constraint apparently, which doesn't make much sense.
I'll try later when I have more time, sorry :-/
Segher
next prev parent reply other threads:[~2020-06-30 21:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 12:39 [PATCH v2] powerpc/uaccess: Use flexible addressing with __put_user()/__get_user() Christophe Leroy
2020-06-29 6:52 ` Christophe Leroy
2020-06-29 11:27 ` Michael Ellerman
2020-06-30 1:19 ` Michael Ellerman
2020-06-30 14:55 ` Christophe Leroy
2020-06-30 16:33 ` Segher Boessenkool
2020-06-30 18:53 ` Christophe Leroy
2020-06-30 21:18 ` Segher Boessenkool [this message]
2020-07-01 7:05 ` Christophe Leroy
2020-07-07 12:44 ` Christophe Leroy
2020-07-07 19:02 ` Christophe Leroy
2020-07-08 4:49 ` Christophe Leroy
2020-08-12 12:32 ` Christophe Leroy
2020-08-12 19:30 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630211817.GZ3598@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).