From: Vinod Koul <vkoul@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tobias Klauser <tklauser@distanz.ch>,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning
Date: Wed, 1 Jul 2020 19:06:43 +0530 [thread overview]
Message-ID: <20200701133643.GZ2599@vkoul-mobl> (raw)
In-Reply-To: <20200701131902.GC27013@pendragon.ideasonboard.com>
On 01-07-20, 16:19, Laurent Pinchart wrote:
> Hi Tobias,
>
> Thank you for the patch.
>
> On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias Klauser wrote:
> > This fixes the following compiler warning when building with
> > CONFIG_PM && !CONFIG_PM_SLEEP:
> >
> > drivers/phy/xilinx/phy-zynqmp.c:830:12: warning: ‘xpsgtr_resume’ defined but not used [-Wunused-function]
> > 830 | static int xpsgtr_resume(struct device *dev)
> > | ^~~~~~~~~~~~~
> > drivers/phy/xilinx/phy-zynqmp.c:819:12: warning: ‘xpsgtr_suspend’ defined but not used [-Wunused-function]
> > 819 | static int xpsgtr_suspend(struct device *dev)
> > | ^~~~~~~~~~~~~~
>
> Oops :-S Sorry about that.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Vinod or Kishon, can you pick this patch up, or do I need to send a pull
> request ? (It's my first driver in the PHY subsystem so I don't know
> what the usual practices are there)
patches are welcome :-)
>
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > ---
> > drivers/phy/xilinx/phy-zynqmp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
> > index 8babee2ce9ec..22a0ae635797 100644
> > --- a/drivers/phy/xilinx/phy-zynqmp.c
> > +++ b/drivers/phy/xilinx/phy-zynqmp.c
> > @@ -815,7 +815,7 @@ static struct phy *xpsgtr_xlate(struct device *dev,
> > * Power Management
> > */
> >
> > -#ifdef CONFIG_PM
> > +#ifdef CONFIG_PM_SLEEP
How about marking it as __maybe_unused instead?
--
~Vinod
next prev parent reply other threads:[~2020-07-01 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:04 [PATCH] phy: zynqmp: Fix unused-function compiler warning Tobias Klauser
2020-07-01 13:19 ` Laurent Pinchart
2020-07-01 13:36 ` Vinod Koul [this message]
2020-07-01 13:44 ` Laurent Pinchart
2020-07-01 13:55 ` Vinod Koul
2020-07-01 14:00 ` Tobias Klauser
2020-07-01 14:01 ` Laurent Pinchart
2020-07-01 14:07 ` Tobias Klauser
2020-07-01 14:09 ` Laurent Pinchart
2020-07-01 14:10 ` [PATCH v2] " Tobias Klauser
2020-07-01 15:05 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701133643.GZ2599@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).