On Tue, Jun 30, 2020 at 08:52:02PM +0200, Christoph Fritz wrote: > This patch adds support for ON Semiconductor FAN53880 regulator. > > The FAN53880 is an I2C porgrammable power management IC (PMIC) > that contains a BUCK (step-down converter), four LDOs (low dropouts) > and one BOOST (step-up converter). It is designed for mobile power > applications. This doesn't build with current code, there are *many* errors in the form /mnt/kernel/drivers/regulator/fan53880.c:48:52: error: array type has incomplete element type 'struct regulator_linear_range' .linear_ranges = (struct regulator_linear_range[]) { \ ^ /mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO' FAN53880_LDO(1, "VIN12", 2800000), ^~~~~~~~~~~~ In file included from /mnt/kernel/drivers/regulator/fan53880.c:5: /mnt/kernel/include/linux/regulator/driver.h:46:2: error: field name not in record or union initializer .min = _min_uV, \ ^ /mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro 'REGULATOR_LINEAR_RANGE' REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \ ^~~~~~~~~~~~~~~~~~~~~~ /mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO' FAN53880_LDO(1, "VIN12", 2800000), ^~~~~~~~~~~~ /mnt/kernel/include/linux/regulator/driver.h:46:2: note: (near initialization for '(anonymous)') .min = _min_uV, \ ^ /mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro 'REGULATOR_LINEAR_RANGE' REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \ ^~~~~~~~~~~~~~~~~~~~~~ /mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro 'FAN53880_LDO' FAN53880_LDO(1, "VIN12", 2800000), ^~~~~~~~~~~~ /mnt/kernel/include/linux/regulator/driver.h:47:2: error: field name not in record or union initializer .min_sel = _min_sel, \ ^ most likely due to the conversion introduced in 60ab7f4153b6af46 (regulator: use linear_ranges helper). Please rebase against current code.