From: "Ondřej Jirman" <megous@megous.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: linux-sunxi@googlegroups.com,
"Thierry Reding" <thierry.reding@gmail.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Guido Günther" <agx@sigxcpu.org>,
"Purism Kernel Team" <kernel@puri.sm>,
"Rob Herring" <robh+dt@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Samuel Holland" <samuel@sholland.org>,
"Martijn Braam" <martijn@brixit.nl>,
"Luca Weiss" <luca@z3ntu.xyz>, "Bhushan Shah" <bshah@kde.org>
Subject: Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support
Date: Wed, 1 Jul 2020 20:57:41 +0200 [thread overview]
Message-ID: <20200701185741.z5cga3b7z4gmba6u@core.my.home> (raw)
In-Reply-To: <78C72279-99DB-4FDE-81B3-1CF6BEF80BBF@aosc.io>
Hi Icenowy,
On Wed, Jul 01, 2020 at 08:01:14PM +0800, Icenowy Zheng wrote:
>
>
> 于 2020年7月1日 GMT+08:00 下午6:31:26, Ondrej Jirman <megous@megous.com> 写到:
> >Pinephone has a Goodix GT917S capacitive touchscreen controller on
> >I2C0 bus. Add support for it.
> >
> >Signed-off-by: Ondrej Jirman <megous@megous.com>
> >Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >---
> > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> >diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> >b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> >index 85a7aa5efd32..2d5694446d17 100644
> >--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> >+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> >@@ -123,6 +123,25 @@ &ehci1 {
> > status = "okay";
> > };
> >
> >+&i2c0 {
> >+ pinctrl-names = "default";
> >+ pinctrl-0 = <&i2c0_pins>;
> >+ status = "okay";
> >+
> >+ touchscreen@5d {
> >+ compatible = "goodix,gt917s", "goodix,gt911";
>
> Please drop gt911 here. GT917S belong to the GT1x product line, not the same line with GT911.
>
> You will see this in the driver.
Right. I'll do so in v8.
thnk you and regards,
o.
> >+ reg = <0x5d>;
> >+ interrupt-parent = <&pio>;
> >+ interrupts = <7 4 IRQ_TYPE_LEVEL_HIGH>; /* PH4 */
> >+ irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
> >+ reset-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
> >+ AVDD28-supply = <®_ldo_io0>;
> >+ VDDIO-supply = <®_ldo_io0>;
> >+ touchscreen-size-x = <720>;
> >+ touchscreen-size-y = <1440>;
> >+ };
> >+};
> >+
> > &i2c1 {
> > status = "okay";
> >
next prev parent reply other threads:[~2020-07-01 18:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 10:31 [PATCH v6 00/13] Add support for PinePhone LCD panel Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 01/13] dt-bindings: vendor-prefixes: Add Xingbangda Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 to yaml Ondrej Jirman
2020-07-01 15:58 ` Guido Günther
2020-07-01 16:07 ` Sam Ravnborg
2020-07-01 16:32 ` Ondřej Jirman
2020-07-01 10:31 ` [PATCH v6 03/13] dt-bindings: panel: Add compatible for Xingbangda XBD599 panel Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703 Ondrej Jirman
2020-07-01 16:00 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 05/13] drm/panel: st7703: Rename functions from jh057n prefix " Ondrej Jirman
2020-07-01 16:01 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 06/13] drm/panel: st7703: Prepare for supporting multiple panels Ondrej Jirman
2020-07-01 16:02 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 07/13] drm/panel: st7703: Move code specific to jh057n closer together Ondrej Jirman
2020-07-01 16:02 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback Ondrej Jirman
2020-07-01 16:02 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 09/13] drm/panel: st7703: Add support for Xingbangda XBD599 Ondrej Jirman
2020-07-01 16:03 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 10/13] drm/panel: st7703: Enter sleep after display off Ondrej Jirman
2020-07-01 16:04 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators Ondrej Jirman
2020-07-01 16:04 ` Guido Günther
2020-07-01 10:31 ` [PATCH v6 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone Ondrej Jirman
2020-07-01 10:31 ` [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Ondrej Jirman
2020-07-01 12:01 ` Icenowy Zheng
2020-07-01 18:57 ` Ondřej Jirman [this message]
2020-07-01 15:25 ` [PATCH v6 00/13] Add support for PinePhone LCD panel Sam Ravnborg
2020-07-01 16:30 ` Ondřej Jirman
2020-07-01 16:37 ` Linus Walleij
2020-07-01 15:54 ` Guido Günther
2020-07-01 16:42 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701185741.z5cga3b7z4gmba6u@core.my.home \
--to=megous@megous.com \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=bshah@kde.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=kernel@puri.sm \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=luca@z3ntu.xyz \
--cc=martijn@brixit.nl \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).