From: Dominique Martinet <asmadeus@codewreck.org>
To: Jianyong Wu <Jianyong.Wu@arm.com>
Cc: "ericvh@gmail.com" <ericvh@gmail.com>,
"lucho@ionkov.net" <lucho@ionkov.net>,
"v9fs-developer@lists.sourceforge.net"
<v9fs-developer@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steve Capper <Steve.Capper@arm.com>, Kaly Xin <Kaly.Xin@arm.com>,
Justin He <Justin.He@arm.com>, Wei Chen <Wei.Chen@arm.com>
Subject: Re: [PATCH v2] 9p: retrieve fid from file when file instance exist.
Date: Thu, 2 Jul 2020 09:56:27 +0200 [thread overview]
Message-ID: <20200702075627.GA23996@nautica> (raw)
In-Reply-To: <HE1PR0802MB25552E53839BA81FB26210ABF46D0@HE1PR0802MB2555.eurprd08.prod.outlook.com>
Jianyong Wu wrote on Thu, Jul 02, 2020:
> Yeah, should check fid before "v9fs_fid_lookup", how about
>
> if (iattr->ia_valid & ATTR_FILE) {
> fid = iattr->ia_file->private_data;
> WARN_ON(!fid);
> }
> If (!fid)
> fid = v9fs_fid_lookup(dentry);
Yes, that would be fine.
--
Dominique
next prev parent reply other threads:[~2020-07-02 7:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 2:38 [PATCH v2] 9p: retrieve fid from file when file instance exist Jianyong Wu
2020-07-01 10:59 ` Dominique Martinet
2020-07-02 1:09 ` Jianyong Wu
2020-07-02 7:56 ` Dominique Martinet [this message]
2020-07-02 9:54 ` Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702075627.GA23996@nautica \
--to=asmadeus@codewreck.org \
--cc=Jianyong.Wu@arm.com \
--cc=Justin.He@arm.com \
--cc=Kaly.Xin@arm.com \
--cc=Steve.Capper@arm.com \
--cc=Wei.Chen@arm.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).