From: Qais Yousef <qais.yousef@arm.com>
To: Phil Auld <pauld@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v2] Sched: Add a tracepoint to track rq->nr_running
Date: Thu, 2 Jul 2020 11:54:36 +0100 [thread overview]
Message-ID: <20200702105435.na2vumpnov5w5tis@e107158-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200629192303.GC120228@lorien.usersys.redhat.com>
On 06/29/20 15:23, Phil Auld wrote:
> Add a bare tracepoint trace_sched_update_nr_running_tp which tracks
> ->nr_running CPU's rq. This is used to accurately trace this data and
> provide a visualization of scheduler imbalances in, for example, the
> form of a heat map. The tracepoint is accessed by loading an external
> kernel module. An example module (forked from Qais' module and including
> the pelt related tracepoints) can be found at:
>
> https://github.com/auldp/tracepoints-helpers.git
>
> A script to turn the trace-cmd report output into a heatmap plot can be
> found at:
>
> https://github.com/jirvoz/plot-nr-running
>
> The tracepoints are added to add_nr_running() and sub_nr_running() which
> are in kernel/sched/sched.h. In order to avoid CREATE_TRACE_POINTS in
> the header a wrapper call is used and the trace/events/sched.h include
> is moved before sched.h in kernel/sched/core.
>
> Signed-off-by: Phil Auld <pauld@redhat.com>
> CC: Qais Yousef <qais.yousef@arm.com>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Vincent Guittot <vincent.guittot@linaro.org>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: linux-kernel@vger.kernel.org
> ---
LGTM.
Reviewed-by: Qais Yousef <qais.yousef@arm.com>
Thanks
--
Qais Yousef
next prev parent reply other threads:[~2020-07-02 10:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 14:11 [PATCH] Sched: Add a tracepoint to track rq->nr_running Phil Auld
2020-06-19 16:46 ` Steven Rostedt
2020-06-19 17:34 ` Phil Auld
2020-06-22 12:17 ` Qais Yousef
2020-06-23 19:38 ` Phil Auld
2020-06-24 12:10 ` Qais Yousef
2020-06-29 19:23 ` [PATCH v2] " Phil Auld
2020-07-02 10:54 ` Qais Yousef [this message]
2020-07-09 8:45 ` [tip: sched/core] sched: " tip-bot2 for Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702105435.na2vumpnov5w5tis@e107158-lin.cambridge.arm.com \
--to=qais.yousef@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).