From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2370C433E0 for ; Sun, 5 Jul 2020 00:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA00320870 for ; Sun, 5 Jul 2020 00:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728159AbgGEAx2 (ORCPT ); Sat, 4 Jul 2020 20:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727041AbgGEAx1 (ORCPT ); Sat, 4 Jul 2020 20:53:27 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA946C061794; Sat, 4 Jul 2020 17:53:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 671F8157A9D84; Sat, 4 Jul 2020 17:53:27 -0700 (PDT) Date: Sat, 04 Jul 2020 17:53:26 -0700 (PDT) Message-Id: <20200704.175326.244867033047522334.davem@davemloft.net> To: luobin9@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, luoxianjun@huawei.com, yin.yinshi@huawei.com, cloud.wangxiaoyun@huawei.com, chiqijun@huawei.com Subject: Re: [PATCH net] hinic: fix sending mailbox timeout in aeq event work From: David Miller In-Reply-To: <20200704073243.6842-1-luobin9@huawei.com> References: <20200704073243.6842-1-luobin9@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 04 Jul 2020 17:53:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luo bin Date: Sat, 4 Jul 2020 15:32:43 +0800 > When sending mailbox in the work of aeq event, another aeq event > will be triggered. because the last aeq work is not exited and only > one work can be excuted simultaneously in the same workqueue, mailbox > sending function will return failure of timeout. We create and use > another workqueue to fix this. > > Signed-off-by: Luo bin Applied, thanks.