Re: [PATCH ghak84 v2] audit: purge audit_log_string from the intra-kernel audit API

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3229 bytes --]

Hi Richard,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pcmoore-audit/next]
[also build test WARNING on linux/master linus/master v5.8-rc3 next-20200703]
[cannot apply to security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Richard-Guy-Briggs/audit-purge-audit_log_string-from-the-intra-kernel-audit-API/20200704-010439
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ca464639a1c9dd3944eb055ffd2796e8c2e7639f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> security/apparmor/ipc.c:39:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]
   }
   ^
   security/apparmor/ipc.c:153:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]
   }
   ^
   2 warnings generated.

vim +39 security/apparmor/ipc.c

0ed3b28ab8bf46 John Johansen      2010-07-29  20  
290f458a4f16f9 John Johansen      2017-06-09  21  /**
290f458a4f16f9 John Johansen      2017-06-09  22   * audit_ptrace_mask - convert mask to permission string
290f458a4f16f9 John Johansen      2017-06-09  23   * @mask: permission mask to convert
cd81837f196754 Richard Guy Briggs 2020-07-03  24   *
cd81837f196754 Richard Guy Briggs 2020-07-03  25   * Returns: pointer to static string
290f458a4f16f9 John Johansen      2017-06-09  26   */
cd81837f196754 Richard Guy Briggs 2020-07-03  27  static const char *audit_ptrace_mask(u32 mask)
290f458a4f16f9 John Johansen      2017-06-09  28  {
290f458a4f16f9 John Johansen      2017-06-09  29  	switch (mask) {
290f458a4f16f9 John Johansen      2017-06-09  30  	case MAY_READ:
cd81837f196754 Richard Guy Briggs 2020-07-03  31  		return "read";
290f458a4f16f9 John Johansen      2017-06-09  32  	case MAY_WRITE:
cd81837f196754 Richard Guy Briggs 2020-07-03  33  		return "trace";
290f458a4f16f9 John Johansen      2017-06-09  34  	case AA_MAY_BE_READ:
cd81837f196754 Richard Guy Briggs 2020-07-03  35  		return "readby";
290f458a4f16f9 John Johansen      2017-06-09  36  	case AA_MAY_BE_TRACED:
cd81837f196754 Richard Guy Briggs 2020-07-03  37  		return "tracedby";
290f458a4f16f9 John Johansen      2017-06-09  38  	}
290f458a4f16f9 John Johansen      2017-06-09 @39  }
290f458a4f16f9 John Johansen      2017-06-09  40  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75313 bytes --]