From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: exynos: Add minimal bootargs
Date: Sat, 4 Jul 2020 12:22:46 +0200 [thread overview]
Message-ID: <20200704102246.GA5975@kozik-lap> (raw)
In-Reply-To: <000801d6516a$b6efcb40$24cf61c0$@samsung.com>
On Sat, Jul 04, 2020 at 12:19:40AM +0530, Alim Akhtar wrote:
> Adding Krzysztof's correct email address.
> Sorry about noise.
>
> > -----Original Message-----
> > From: Alim Akhtar <alim.akhtar@samsung.com>
> > Sent: 03 July 2020 23:56
> > To: rzk@kernel.org
> > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> > robh+dt@kernel.org; Alim Akhtar <alim.akhtar@samsung.com>
> > Subject: [PATCH] arm64: dts: exynos: Add minimal bootargs
> >
> > Add minimal bootargs to enable earlycon and console.
> > This really useful in case kernel has crashed early in boot process.
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > index 790f12ca8981..d7b42d5a3b2d 100644
> > --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> > @@ -24,6 +24,7 @@
> >
> > chosen {
> > stdout-path = &serial_2;
> > + bootargs = "earlycon=exynos4210,0x14c30000
> > console=ttySAC0,115200n8";
Hi,
The console is already chosen by stdout-path and earlycon would use it
as well, so no need for the address. It should be just "earlycon" if you
want to enable it unconditionally.
Also, why did you use different serial for console?
However the question is, are you sure you want earlycon on every,
including successful boot? On most of the boards we do not enable by
default. If developer needs, he can choose it for example via U-Boot
"setenv opts earlycon".
However it's a development kit so it could be enabled on default...
Best regards,
Krzysztof
> > };
> >
> > memory@40000000 {
> >
> > base-commit: 9e50b94b3eb0d859a2586b5a40d7fd6e5afd9210
> > --
> > 2.17.1
>
>
next prev parent reply other threads:[~2020-07-04 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200703184543epcas5p4adb3db7693094c72477b8469d9f205ba@epcas5p4.samsung.com>
2020-07-03 18:25 ` [PATCH] arm64: dts: exynos: Add minimal bootargs Alim Akhtar
2020-07-03 18:49 ` Alim Akhtar
2020-07-04 10:22 ` Krzysztof Kozlowski [this message]
2020-07-05 1:39 ` Alim Akhtar
2020-07-05 18:09 ` 'Krzysztof Kozlowski'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704102246.GA5975@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).