From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 8/9] bus: mhi: core: Read and save device hardware information from BHI
Date: Sat, 4 Jul 2020 21:17:45 +0530 [thread overview]
Message-ID: <20200704154745.GH3066@Mani-XPS-13-9360> (raw)
In-Reply-To: <1593448782-8385-9-git-send-email-bbhatt@codeaurora.org>
On Mon, Jun 29, 2020 at 09:39:41AM -0700, Bhaumik Bhatt wrote:
> Device hardware specific information such as serial number and the OEM
> PK hash can be read using BHI and saved on host to identify the
> endpoint.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/core/boot.c | 17 ++++++++++++++++-
> include/linux/mhi.h | 6 ++++++
> 2 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
> index 0b38014..24422f5 100644
> --- a/drivers/bus/mhi/core/boot.c
> +++ b/drivers/bus/mhi/core/boot.c
> @@ -392,13 +392,28 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl)
> void *buf;
> dma_addr_t dma_addr;
> size_t size;
> - int ret;
> + int i, ret;
>
> if (MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state)) {
> dev_err(dev, "Device MHI is not in valid state\n");
> return;
> }
>
> + /* save hardware info from BHI */
> + ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->bhi, BHI_SERIALNU,
> + &mhi_cntrl->serial_number);
> + if (ret)
> + dev_err(dev, "Could not capture serial number via BHI\n");
> +
> + for (i = 0; i < ARRAY_SIZE(mhi_cntrl->oem_pk_hash); i++) {
> + ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->bhi, BHI_OEMPKHASH(i),
> + &mhi_cntrl->oem_pk_hash[i]);
> + if (ret) {
> + dev_err(dev, "Could not capture OEM PK HASH via BHI\n");
> + break;
> + }
> + }
> +
> /* If device is in pass through, do reset to ready state transition */
> if (mhi_cntrl->ee == MHI_EE_PTHRU)
> goto fw_load_ee_pthru;
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index b1e8b4f..dad6246 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -16,6 +16,8 @@
> #include <linux/wait.h>
> #include <linux/workqueue.h>
>
> +#define MHI_MAX_OEM_PK_HASH_SEGMENTS 16
> +
> struct mhi_chan;
> struct mhi_event;
> struct mhi_ctxt;
> @@ -315,6 +317,8 @@ struct mhi_controller_config {
> * @device_number: MHI controller device number
> * @major_version: MHI controller major revision number
> * @minor_version: MHI controller minor revision number
> + * @serial_number: MHI controller serial number obtained from BHI
> + * @oem_pk_hash: MHI controller OEM PK Hash obtained from BHI
> * @mhi_event: MHI event ring configurations table
> * @mhi_cmd: MHI command ring configurations table
> * @mhi_ctxt: MHI device context, shared memory between host and device
> @@ -394,6 +398,8 @@ struct mhi_controller {
> u32 device_number;
> u32 major_version;
> u32 minor_version;
> + u32 serial_number;
> + u32 oem_pk_hash[MHI_MAX_OEM_PK_HASH_SEGMENTS];
>
> struct mhi_event *mhi_event;
> struct mhi_cmd *mhi_cmd;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-07-04 15:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 16:39 [PATCH v4 0/9] Introduce features and debugfs/sysfs entries for MHI Bhaumik Bhatt
2020-06-29 16:39 ` [PATCH v4 1/9] bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task() declaration Bhaumik Bhatt
2020-07-04 14:32 ` Manivannan Sadhasivam
2020-06-29 16:39 ` [PATCH v4 2/9] bus: mhi: core: Abort suspends due to outgoing pending packets Bhaumik Bhatt
2020-07-04 14:35 ` Manivannan Sadhasivam
2020-06-29 16:39 ` [PATCH v4 3/9] bus: mhi: core: Use helper API to trigger a non-blocking host resume Bhaumik Bhatt
2020-07-04 14:47 ` Manivannan Sadhasivam
2020-07-08 20:53 ` bbhatt
2020-07-16 6:08 ` Manivannan Sadhasivam
2020-06-29 16:39 ` [PATCH v4 4/9] bus: mhi: core: Trigger a host resume when device vote is requested Bhaumik Bhatt
2020-07-04 14:56 ` Manivannan Sadhasivam
2020-06-29 16:39 ` [PATCH v4 5/9] bus: mhi: core: Use generic name field for an MHI device Bhaumik Bhatt
2020-07-04 15:08 ` Manivannan Sadhasivam
2020-06-29 16:39 ` [PATCH v4 6/9] bus: mhi: core: Introduce helper function to check device state Bhaumik Bhatt
2020-07-04 15:13 ` Manivannan Sadhasivam
2020-06-29 16:39 ` [PATCH v4 7/9] bus: mhi: core: Introduce debugfs entries and counters for MHI Bhaumik Bhatt
2020-07-04 15:41 ` Manivannan Sadhasivam
2020-07-09 19:33 ` bbhatt
2020-07-16 5:01 ` Manivannan Sadhasivam
2020-06-29 16:39 ` [PATCH v4 8/9] bus: mhi: core: Read and save device hardware information from BHI Bhaumik Bhatt
2020-07-04 15:47 ` Manivannan Sadhasivam [this message]
2020-06-29 16:39 ` [PATCH v4 9/9] bus: mhi: core: Introduce sysfs entries for MHI Bhaumik Bhatt
2020-07-04 15:54 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704154745.GH3066@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).