From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-kernel@vger.kernel.org, "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Heiko Stuebner" <heiko.stuebner@theobroma-systems.com>,
"Stephan Gerhold" <stephan@gerhold.net>,
"Lubomir Rintel" <lkundrak@v3.sk>,
"Mark Brown" <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Heiko Stuebner" <heiko@sntech.de>,
"Josua Mayer" <josua.mayer@jm0.eu>,
"Andreas Kemnade" <andreas@kemnade.info>
Subject: Re: [RFC PATCH 08/10] rtc: New driver for RTC in Netronix embedded controller
Date: Sat, 4 Jul 2020 21:23:23 +0200 [thread overview]
Message-ID: <20200704192323.GC2578@latitude> (raw)
In-Reply-To: <20200621001106.GC131826@piout.net>
[-- Attachment #1: Type: text/plain, Size: 3724 bytes --]
Hi,
On Sun, Jun 21, 2020 at 02:11:06AM +0200, Alexandre Belloni wrote:
> On 21/06/2020 00:42:19+0200, Jonathan Neuschäfer wrote:
> > With this driver, mainline Linux can keep its time and date in sync with
> > the vendor kernel.
> >
> > Advanced functionality like alarm and automatic power-on is not yet
> > supported.
> >
>
> Please report the results of rtctest (from the kernel tree) [...]
# ./rtctest
[==========] Running 7 tests from 2 test cases.
[ RUN ] rtc.date_read
../../tools/testing/selftests/rtc/rtctest.c:49:date_read:Current RTC date/time is 11/04/2006 23:11:23.
[ OK ] rtc.date_read
[ RUN ] rtc.uie_read
[ 180.651355] random: crng init done
uie_read: Test terminated by timeout
[ FAIL ] rtc.uie_read
[ RUN ] rtc.uie_select
../../tools/testing/selftests/rtc/rtctest.c:98:uie_select:Expected 0 (0) != rc (0)
uie_select: Test terminated by assertion
[ FAIL ] rtc.uie_select
[ RUN ] rtc.alarm_alm_set
../../tools/testing/selftests/rtc/rtctest.c:129:alarm_alm_set:skip alarms are not supported.
[ OK ] rtc.alarm_alm_set
[ RUN ] rtc.alarm_wkalm_set
../../tools/testing/selftests/rtc/rtctest.c:185:alarm_wkalm_set:skip alarms are not supported.
[ OK ] rtc.alarm_wkalm_set
[ RUN ] rtc.alarm_alm_set_minute
../../tools/testing/selftests/rtc/rtctest.c:231:alarm_alm_set_minute:skip alarms are not supported.
[ OK ] rtc.alarm_alm_set_minute
[ RUN ] rtc.alarm_wkalm_set_minute
../../tools/testing/selftests/rtc/rtctest.c:287:alarm_wkalm_set_minute:skip alarms are not supported.
[ OK ] rtc.alarm_wkalm_set_minute
[==========] 5 / 7 tests passed.
[ FAILED ]
> [...] and rtc-range
> (https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/rtc-tools.git/tree/rtc-range.c)
# ./rtc-range
Testing 1970-01-01 00:00:00.
KO Read back 2226-01-01 00:01:00.
Testing 2000-02-28 23:59:59.
KO Read back 2000-02-28 23:28:23.
Testing 2020-02-28 23:59:59.
KO Read back 2020-02-28 23:28:23.
Testing 2038-01-19 03:14:07.
KO Read back 2038-01-19 03:19:03.
Testing 2069-12-31 23:59:59.
KO Read back 2069-12-31 23:31:23.
Testing 2079-12-31 23:59:59.
KO Read back 2079-12-31 23:31:23.
Testing 2099-12-31 23:59:59.
KO Read back 2099-12-31 23:31:23.
Testing 2255-12-31 23:59:59.
KO Read back 2255-12-31 23:31:23.
Testing 2100-02-28 23:59:59.
KO Read back 2100-02-28 23:28:23.
Testing 2106-02-07 06:28:15.
KO Read back 2106-02-07 06:07:06.
Testing 2262-04-11 23:47:16.
KO Read back 2006-04-11 23:11:23.
Something is very wrong here.
I'll try to fix the failures in rtctest and the problems in rtc-range
before version 2 of the patchset.
(The 2255 date was my addition, because I suspect this to be the upper
limit of the RTC's range.)
[...]
> > +config RTC_DRV_NTXEC
> > + tristate "Netronix embedded controller RTC driver"
> > + depends on MFD_NTXEC
> > +
>
> This should get an help section.
Ok, I'll add one.
[...]
> > +#include <linux/rtc.h>
> > +#include <linux/mfd/ntxec.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/types.h>
> > +#include <linux/module.h>
> > +#include <linux/of_device.h>
>
> Please sort the includes.
Will do.
[...]
> > + rtcdev = devm_rtc_device_register(&pdev->dev, "ntxec-rtc",
> > + &ntxec_rtc_ops, THIS_MODULE);
>
> Please use devm_rtc_allocate_device and rtc_register_device. Also, set
> the supported range (->range_min and ->range_max).
Ok, will do.
Thanks for the review and the testing tips.
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-04 19:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 22:42 [RFC PATCH 02/10] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 03/10] dt-bindings: mfd: Add binding for Netronix's embedded controller Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 04/10] mfd: Add base driver for Netronix " Jonathan Neuschäfer
2020-06-22 10:55 ` Lee Jones
2020-06-28 8:11 ` Jonathan Neuschäfer
2020-06-27 8:17 ` Andreas Kemnade
2020-06-28 8:29 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 05/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC Jonathan Neuschäfer
2020-06-21 18:41 ` Andreas Kemnade
2020-08-23 22:42 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 06/10] pwm: ntxec: Add driver " Jonathan Neuschäfer
2020-06-22 8:18 ` Uwe Kleine-König
2020-07-03 16:15 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 07/10] dt-bindings: rtc: Add bindings for Netronix embedded controller RTC Jonathan Neuschäfer
2020-06-21 0:02 ` Alexandre Belloni
2020-06-26 21:55 ` Andreas Kemnade
2020-07-03 17:04 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 08/10] rtc: New driver for RTC in Netronix embedded controller Jonathan Neuschäfer
2020-06-21 0:11 ` Alexandre Belloni
2020-07-04 19:23 ` Jonathan Neuschäfer [this message]
2020-06-20 22:42 ` [RFC PATCH 09/10] MAINTAINERS: Add entry for " Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 10/10] ARM: dts: imx50-kobo-aura: Add " Jonathan Neuschäfer
2020-06-20 22:46 ` [RFC PATCH 02/10] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704192323.GC2578@latitude \
--to=j.neuschaefer@gmx.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allen.chen@ite.com.tw \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=josua.mayer@jm0.eu \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).