* [PATCH v2] usb: gadget: function: fix missing spinlock in f_uac1_legacy
@ 2020-07-05 6:24 qiang.zhang
0 siblings, 0 replies; 3+ messages in thread
From: qiang.zhang @ 2020-07-05 6:24 UTC (permalink / raw)
To: balbi; +Cc: gregkh, colin.king, linux-usb, linux-kernel
From: Zhang Qiang <qiang.zhang@windriver.com>
Add a missing spinlock protection to the add operation of the play_queue
in "f_audio_out_ep_complete" function.
Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
---
v1->v2:
Add missing changelog.
drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 349deae7cabd..e2d7f69128a0 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req)
/* Copy buffer is full, add it to the play_queue */
if (audio_buf_size - copy_buf->actual < req->actual) {
+ spin_lock_irq(&audio->lock);
list_add_tail(©_buf->list, &audio->play_queue);
+ spin_unlock_irq(&audio->lock);
schedule_work(&audio->playback_work);
copy_buf = f_audio_buffer_alloc(audio_buf_size);
if (IS_ERR(copy_buf))
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: gadget: function: fix missing spinlock in f_uac1_legacy
2020-07-05 6:16 qiang.zhang
@ 2020-07-06 10:31 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-07-06 10:31 UTC (permalink / raw)
To: qiang.zhang; +Cc: balbi, colin.king, linux-usb, linux-kernel
On Sun, Jul 05, 2020 at 02:16:16PM +0800, qiang.zhang@windriver.com wrote:
> From: Zhang Qiang <qiang.zhang@windriver.com>
>
> Add a missing spinlock protection to the add operation of the "audio->play_queue"
> in "f_audio_out_ep_complete" function.
That says _what_ you did, but not _why_ you did that. Why is a lock
needed here? What does this protect?
What kernel commit does this "fix"? Put that in the "Fixes:" line, and
probably you need a "cc: stable" in that area too, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] usb: gadget: function: fix missing spinlock in f_uac1_legacy
@ 2020-07-05 6:16 qiang.zhang
2020-07-06 10:31 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: qiang.zhang @ 2020-07-05 6:16 UTC (permalink / raw)
To: balbi; +Cc: gregkh, colin.king, linux-usb, linux-kernel
From: Zhang Qiang <qiang.zhang@windriver.com>
Add a missing spinlock protection to the add operation of the "audio->play_queue"
in "f_audio_out_ep_complete" function.
Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
---
v1->v2:
Add changelog text.
drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 349deae7cabd..e2d7f69128a0 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req)
/* Copy buffer is full, add it to the play_queue */
if (audio_buf_size - copy_buf->actual < req->actual) {
+ spin_lock_irq(&audio->lock);
list_add_tail(©_buf->list, &audio->play_queue);
+ spin_unlock_irq(&audio->lock);
schedule_work(&audio->playback_work);
copy_buf = f_audio_buffer_alloc(audio_buf_size);
if (IS_ERR(copy_buf))
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-06 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-05 6:24 [PATCH v2] usb: gadget: function: fix missing spinlock in f_uac1_legacy qiang.zhang
-- strict thread matches above, loose matches on Subject: below --
2020-07-05 6:16 qiang.zhang
2020-07-06 10:31 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).