From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9448C433DF for ; Sun, 5 Jul 2020 07:34:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 807DB20737 for ; Sun, 5 Jul 2020 07:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593934472; bh=M0Nl0piVJywOWOh5GkXic1ooxXaj3OJL4yQvkIzhHc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2ORH2ThWaRm7O2YsOJHqThmNRSiho7SCTWLNKpqlPk07ZaAPbwx7JczRer4IhQRaH HtRsnSv4TzWGExBotNZJN+VQlt8XQB11AV2ofZt/bZt8XpFkMf89I65qsB9EtysqUP UHLCFfKlriYsjvFHOEVayqiD+ZqgQ6wW0AsC6tKU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgGEHeb (ORCPT ); Sun, 5 Jul 2020 03:34:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbgGEHea (ORCPT ); Sun, 5 Jul 2020 03:34:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C32720702; Sun, 5 Jul 2020 07:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593934470; bh=M0Nl0piVJywOWOh5GkXic1ooxXaj3OJL4yQvkIzhHc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jeRjaa14xmg7VN1dNQTqNABuDjz5ik3ypPX5CDQdd7lbMcZ42I3Ycp9dJuLQ356ST SPZAkO62/Dsek+qBJK8A0e8Q9d6LJKUyfiOf7dlPWFfUTKqe7J6ahukX/P0Qtqo/hC SzJg6nSCHZ5Rp5Ld0cao8dQSiNJ8ZXaKlQjmSuDY= Date: Sun, 5 Jul 2020 09:34:26 +0200 From: Greg Kroah-Hartman To: Heinrich Schuchardt Cc: viro@zeniv.linux.org.uk, mtk.manpages@gmail.com, shuah@kernel.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-man@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 3/3] selftests: add readfile(2) selftests Message-ID: <20200705073426.GA37944@kroah.com> References: <20200704140250.423345-1-gregkh@linuxfoundation.org> <20200704140250.423345-4-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 05, 2020 at 03:41:48AM +0200, Heinrich Schuchardt wrote: > On 7/4/20 4:02 PM, Greg Kroah-Hartman wrote: > > Test the functionality of readfile(2) in various ways. > > Hello Greg, > > I expect readfile() to generate fanotify events FAN_OPEN_PERM, FAN_OPEN, > FAN_ACCESS_PERM, FAN_ACCESS, FAN_CLOSE_NOWRITE in this sequence. Yes, it should, I don't think I do anything unique here when it comes to vfs accesses that would go around those events. > Looking at patch 1/3 you took care of notifications. Would this deserve > testing here? Possibly, do we have other in-tree tests of syscalls that validate those events properly being created? thanks, greg k-h