From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tamseel Shams <m.shams@samsung.com>
Cc: kgene@kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, alim.akhtar@samsung.com
Subject: Re: [PATCH v3] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC
Date: Mon, 6 Jul 2020 10:13:07 +0200 [thread overview]
Message-ID: <20200706081307.GA13025@kozik-lap> (raw)
In-Reply-To: <20200704140646.66528-1-m.shams@samsung.com>
On Sat, Jul 04, 2020 at 07:36:46PM +0530, Tamseel Shams wrote:
> In few older Samsung SoCs like s3c2410, s3c2412
> and s3c2440, UART IP is having 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210,
> exynos5433, and exynos4210 UART is having only 1
> interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following warning:
> "IRQ index 1 not found" on recent platforms.
>
> This patch re-factors the IRQ resources handling for
> each platform and hence fixing the above warnings seen
> on some platforms.
>
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> Removed the logic of irq_cnt and directly using
> s3c24xx_serial_has_interrupt_mask() to check for
> number of interrupt lines.
>
> drivers/tty/serial/samsung_tty.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 6ef614d8648c..8a955f3d8975 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1908,10 +1908,13 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
> else {
> port->irq = ret;
> ourport->rx_irq = ret;
> - ourport->tx_irq = ret + 1;
> + if (s3c24xx_serial_has_interrupt_mask(port))
> + ourport->tx_irq = ret;
Hi,
I don't understand: Why do you assign here the same interrupt as RX?
Best regards,
Krzysztof
> + else
> + ourport->tx_irq = ret + 1;
> }
>
> - ret = platform_get_irq(platdev, 1);
> + ret = platform_get_irq_optional(platdev, 1);
> if (ret > 0)
> ourport->tx_irq = ret;
> /*
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-07-06 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200704142658epcas5p254ae909fedb07dda58cece5d6d5252b4@epcas5p2.samsung.com>
2020-07-04 14:06 ` [PATCH v3] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC Tamseel Shams
2020-07-06 8:13 ` Krzysztof Kozlowski [this message]
2020-07-13 14:03 ` M Tamseel Shams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706081307.GA13025@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.shams@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).